@emmadumbiSubmitted 2 months ago
oduwa-A
@oduwa-AAll comments
- @oduwa-APosted about 2 months ago
Pretty good! Make sure to be aware of the padding, as your padding isn't exact to the design, alittle short. Using margin-inline to center your text was pretty genius of you, I didn't know such an element existed.
Marked as helpful1 - @GustavoSDSSubmitted about 2 years agoWhat are you most proud of, and what would you do differently next time?
The desing.
What challenges did you encounter, and how did you overcome them?No challenges found.
What specific areas of your project would you like help with?I'm fine for the moment.
@oduwa-APosted 2 months agoHonestly there's not much to critique or improve here congrats.
One thing I did notice, as I was messing with the responsiveness of the site, the h1 doesn't format properly as you move closer to mobile screens. I would say watch out for that, either by defining the textbox differently or removing the second phrase from the h1 completely and making it something else.
Marked as helpful1 - @Jan-Dev0Submitted 2 months agoWhat are you most proud of, and what would you do differently next time?
I used BEM for naming classes.
What challenges did you encounter, and how did you overcome them?I encountered difficulties with the image shrinking due to margins reducing the available width, which affected its aspect ratio. I resolved this by using a fixed width for the image.
What specific areas of your project would you like help with?I would appreciate advice on more effective methods for addressing image shrinking and spacing issues within a flexbox layout. Any suggestions for improving responsiveness or optimizing the layout would be helpful.
@oduwa-APosted 2 months agoI don't really have much critique for this since it was well made. Maybe invest into object-fit if possible for image spacing, but otherwise I don't know. Good job however.
0 - @AndDevISubmitted 3 months agoWhat specific areas of your project would you like help with?
Centralizar todo o Article usando o TailwindCSS
@oduwa-APosted 3 months agoUnfortunately I don't use TailwindCSS so I can't help you on that but the whole thing is excellent regardless.
0 - @ManuelGarcia2207Submitted 3 months agoWhat are you most proud of, and what would you do differently next time?
Apply more interactive effects with CSS3
What challenges did you encounter, and how did you overcome them?In stacking or maintaining the correct structure of the elements to be displayed
What specific areas of your project would you like help with?Learn more CSS techniques to arrange the elements of a page, such as links in this case.
@oduwa-APosted 3 months agoHey nice work, it's pretty much perfect. Looking through the code, I don't see too many flaws with it. I did notice the links don't grow as the page changes and increases the size of the project, which isn't egregious now, but might be important to remember for more complicated projects. Otherwise, I can't really find much to critique. Nice work.
0 - @IjechidiSubmitted 4 months ago@oduwa-APosted 3 months ago
Hey! Nice attempt! The overall framework is there, loving the yellow learning box. I struggled on that heavily so seeing you get it down makes me alittle jealous haha. I will say however, be wary of the box-radius since it is alittle too sharp compared to the example, as well as the padding not being as strong as it should be. Finally, the width is alittle too wide. Overall though, if you were to correct those things, you would have a near perfect solution. Congrats!
Marked as helpful0 - @beardedbe4nSubmitted 3 months agoWhat are you most proud of, and what would you do differently next time?
this was the first time i coded anything that wasn't spoon fed. there was a lot of instruction but the basic things I had to google, it is so different in practice.
What challenges did you encounter, and how did you overcome them?my main challenge was linking the google font, as well as (and I cant figure it out) the top border radius of the qr code
What specific areas of your project would you like help with?the top borders of the qr code image as well as best practices for formatting
@oduwa-APosted 3 months agoYeah the top left and right of the image are not as even as the bottom corners. The problem is padding squishing the image at the top, and altering it far more than intended. By removing padding-top in .imgCode, the radius will do it's thing.
Additionally, the card is a tad bit too small. Although that is not egregious in itself. Also watch out for the font-weight since the contrast between the paragraphs isn't strong enough. And make sure to include a default/backup typeface in the font-family in the top and bottom classes, should the main font fail.
Finally, make sure the to include padding in the first class, .box, so the box can "compress" on itself and grant space.
Otherwise, great attempt for your first time without help! I'm going through the same thing, so seeing your work was enlightening, since it offered an alternate path to how I approached it. And of course, seeing everything, all you did right and the flaws, increased my own understanding alot. Keep it up!
Marked as helpful1
