@isismdSubmitted over 2 years ago
Hello! 👋🏻
I'm still learning and discovering CSS features, any feedback will be appreciated!
If anyone has a suggestion on how to make that main picture looks better in mobile please let me know!😊
Jorge Miguel
@notFacerollAll comments
- @notFacerollPosted over 2 years ago
Hey, awesome work on this one. Layout in general looks great!
On the image issue a suggestion would be:
- Try setting max-width (usually 100%) instead of max-height and control the actual size of the image by resizing its container. Making it so, in some cases, you won't even need to write more media queries for images :). Generally is easier to work with widths on images. Also, you could set display as 'block' for them;
and for other topics:
- You should always have a main element to wrap the main content of the site;
- Avoid using only (or mostly) IDs as a selector for css. IDs have a higher specificity and since classes can be reused, you would need more IDs or use '!important' to override some styles. This topic https://dev.to/clairecodes/reasons-not-to-use-ids-in-css-4ni4 can pretty much explain this better than me.
Aside from that, great job on this one!
Marked as helpful0 - @Boris74000Submitted about 3 years ago
Hi !
I would like feedback on my code, More precisely the part where I apply a filter on the image. I can't seem to have the same rendering.
Thank you !
@notFacerollPosted about 3 years agoHey!
Using mix-blend-modes to achieve the correct/similar filter would be really helpful. You could just change the background-image from the container to a background-color and insert an img element there with the image source and mix them with blend mode, or just make two properties "background-image" and "background-color" and mix them. Check these links for a more accurate answer!
- https://css-tricks.com/basics-css-blend-modes/
- https://css-tricks.com/almanac/properties/m/mix-blend-mode/
- https://www.w3schools.com/cssref/tryit.asp?filename=trycss_mix-blend-mode-all
Marked as helpful0
