Skip to content
OverviewSolutions
41
Comments
20
Dolapo
@nofeesahdee

All comments

  • Dolapo•890
    @nofeesahdeePosted 6 months ago

    Your solution looks good beside the provided design, but a tiny colour change can be made to the border. Accessibility is great as well. Well done

    1
  • Dolapo•890
    @nofeesahdeePosted almost 3 years ago

    Great job Kevin, For the accessibility, instead of using div, try use semantic html5 such as main

    Marked as helpful
    1
  • Dolapo•890
    @nofeesahdeePosted almost 3 years ago

    You have done well saajeves

    0
  • Dolapo•890
    @nofeesahdeePosted almost 3 years ago

    Hi paul, great job.

    Here are adjustments you can make to improve accessibility;

    • Use a semantic tag such as <header> <main> to put your contents in landmark
    • Include the contents of your web page aside the <header> and <footer> into the <main> tag
    • Always use an alt text in your images.

    Goodluck

    Marked as helpful
    0
  • Dolapo•890
    @nofeesahdeePosted almost 3 years ago

    Hi Aphrysof, great work

    However, to improve your accessibility, always include an alt text into your image. <img src = "image.png" alt = "image">

    0
  • Dolapo•890
    @nofeesahdeePosted almost 3 years ago

    Hi Nathan, you’ve done a great job. However, you can improve on accessibility by:

    Using <main> tags instead of <div> Format the <img> url properly

    Marked as helpful
    1
  • Dolapo•890
    @nofeesahdeePosted almost 3 years ago

    Hi Francisco, Great work 😊, here’s a little feedback to improve accessibility.

    Use ‘<main>’ tag to include all the other tags instead of <div>, basically what I am saying is, try as much as you can to use html5 semantics where necessary

    Marked as helpful
    1
  • Matías Fuentes•50
    @LeoCaprileSubmitted almost 3 years ago

    Hi Guys! I made this in like 8 hours, in my spare time. I been learning React for like one month, can you give me feed back about the folder arquitecture that I used. Or if i used hooks wrong etc. Thanks!

    React, SCSS, Grid, Flexbox, Context.

    1
    Dolapo•890
    @nofeesahdeePosted almost 3 years ago

    Hi Matias, you’ve done a great job. However, endeavor to include alt text into your images to improve accessibility.

    0
  • Dolapo•890
    @nofeesahdeePosted almost 3 years ago

    Keep at it, it gets easier

    1
  • MANISHA SAMANTA•50
    @manishasamantaSubmitted almost 3 years ago

    I faced problems to place the elements properly. is my approach correct? or I should change the way for positioning ? And please let me know about my mistakes 🙏🙏🙏. Thanks 😊.

    HTML AND CSS

    2
    Dolapo•890
    @nofeesahdeePosted almost 3 years ago

    Hi Manisha, great work.

    Here are a few suggestions to help improve your accessibility and HTML issues;

    • Please check your image format <img src = "./images/....> not `<.\image...>
    • Ensure to wrap your body into a <main> tag.
    • Use semantic HTML tags as much as possible to replace divs

    Keep it up, it gets better.

    Marked as helpful
    0
  • Camila Melo•120
    @IllaMeloSubmitted almost 3 years ago

    Hello everyone!!! This is my response to the challenge and I would like to hear the feedback because I'm still a noob.

    3-Column-preview

    2
    Dolapo•890
    @nofeesahdeePosted almost 3 years ago

    Great work camila, you seem not to have any issues whatsoever. However, you probably forgot to change the background color.

    Keep it up

    Marked as helpful
    1
  • Dolapo•890
    @nofeesahdeePosted almost 3 years ago

    Hi Lucas, great work. To tackle the accessibility issue, you should wrap the body in a <main> tag

    Marked as helpful
    0