@nimrodEDE
@chinmoy33
Submitted
What are you most proud of, and what would you do differently next time?
it is my first project of javascript
What specific areas of your project would you like help with?
although i used media query my site was not responsive when i opened it on mobile , however in laptop on testing the responsiveness it was looking fine . Tried using @media only screen , @media all , but this did not resolve the issue.
hi , good job . Add padding to all the text to make it look abit better . also , change the color to the design color , it would look more profesional. and there is abit of overflow, try to change the media query so the site would be more responsive .
other than that, looks great .
@MattPahuta
Submitted
What are you most proud of, and what would you do differently next time?
Going back to this challenge after more than two years was a journey. There are so many areas of my code I found that I'd over-engineered or overly complicated. I didn't fix everything that should be updated, but revising this project was immensely useful for focusing on more straightforward markup and code and seeing where I've grown.
Wow !
I have a lot to learn from you , your approach is very straight forward and simple . i think i need to take a strong look at it and learn thank you
@alstrow
Submitted
What are you most proud of, and what would you do differently next time?
I am proud that I finished this and learned the properties of the grid such as start and end of columns and rows
What challenges did you encounter, and how did you overcome them?
Making the layout of the grid and the occupation of the boxes in 2 spaces (col or row)
Incredible job with this project ! Very nice use of both grid and flex , havent thought about it myself .
Something to keep in mind:
it is best practice to start the design with a mobile-first approach . because most people enter sites online via their phones .
keep up the good work!
Marked as helpful
@hasnatlubaid
Submitted
nice work , couple of issues:
keep up the good work !
@youngimmortal-p
Submitted
What are you most proud of, and what would you do differently next time?
I am proud of being able to use media queries to display optimal layout for devices with different screen sizes and also being able to advance the project more with my personal idea with javascript.
What challenges did you encounter, and how did you overcome them?
The challenge i encountered was the appropriate use of media queries and i was able to overcome this by making research. You can check out the resource i used in my github repo
What specific areas of your project would you like help with?
Anywhere you think that i should improve on?
you can center the container by giving the body a display:flex and align-items : center.
that should do the trick !
other then that looks great ! keep up the good work .
@ndPnachkrn
Submitted
Cant reach the site. you should fix that.
Other than that , you should use semantic HTML instead of using <h> tags . it can cause a big accessability issue .
you should use a <main> tag to wrap all of the recipe . divide it to sections and use article for the "prepration time" part .
keep up the good work ! good job !
@GaganRatakonda
Submitted
What are you most proud of, and what would you do differently next time?
proud to have developed a clean and responsive design that looks great on all devices.
What challenges did you encounter, and how did you overcome them?
I didn't face any challenges while developing the card.
Very nice job !
notice that the green coloring supposed to be in the location and not the description. other than that , you used buttons instead of <a> , remember that in a real project those need to anchor the user the real social network profiles.
Try to use rem and em units instead of px , that could cause some accessability issues .
good work!
@vladzen13
Submitted
What are you most proud of, and what would you do differently next time?
CSS Grid awesome even for small elements like userpic and username. Not only for page layout.
What specific areas of your project would you like help with?
I am not really happy with card on viewports smaller than 375px.
It starts to shrink but slower than needed to prevent overflow. Could not find a solution in this iteration. Can somebody point me in right direction?
Very nice :)
small adjustments: you should be consistent with your units , adding padding in px units can cause some trouble with accessibility.
very nice use of grid.
@Kalo-Green
Submitted
Well done.
