Skip to content
OverviewSolutions
10
Comments
6
Saumya Verma
@nikkuv

All comments

  • Saumya Verma•565
    @nikkuvPosted almost 3 years ago

    Hye! I'm working on the same project, for now, your one is really good, plus you can use react Dnd for drag and drop in react.

    Marked as helpful
    0
  • Saumya Verma•565
    @nikkuvPosted about 4 years ago

    Hye Akshita ! you can improve the style of your testimonial card and in the footer, the logo is in black, if it is available in SVG you can change the "fill" property to set it white, also you can improve your social media icons, and set "aria-label" to resolve the accessibility issues on both the input and the link.

    1
  • sonickonic•700
    @sonickonicSubmitted about 4 years ago

    My first try to animate a landing page with CSS animations. Even though it is a newbie challenged I found it super interesting for this purpose! 🥳

    Feedback is welcome and appreciated 🚀

    CSS animations, Sass and BEM

    2
    Saumya Verma•565
    @nikkuvPosted about 4 years ago

    All animations are really really cool, there are accessibility issues but if you'll use "aria-label" on your links then it will be fine.

    1
  • Saumya Verma•565
    @nikkuvPosted about 4 years ago

    First, apply all error styles with a class to the element, then select the element in js DOM and add that class to the element using the email regex function with conditionals. For email validation, you can use this email regex function👇

    function validateEmail(email) {
    const re = /^(([^<>()\[\]\\.,;:\s@"]+(\.[^<>()\[\]\\.,;:\s@"]+)*)|(".+"))@((\[[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\])|(([a-zA-Z\-0-9]+\.)+[a-zA-Z]{2,}))$/;
    return re.test(String(email).toLowerCase());
}
    1
  • Saumya Verma•565
    @nikkuvPosted about 4 years ago

    You did a great job on your first project. It almost looks the same as in the design. All you have to do is on your share button set the style of "outline: none" on focus, like this. &:focus{ outline: none; }

    1
  • Saumya Verma•565
    @nikkuvPosted over 4 years ago

    You can solve accessibility issue by using "aria-label" on input and a button of "type=submit" in form:) that was also my first mistake !! And remove the space from your file name for HTML Validation.

    3