Muhammad Uzair• 30
@ItxUzair1
Submitted
nikhilka2305
@nikhilka2305
All comments
- nikhilka2305• 50
@nikhilka2305
Posted
Good work.
- Usage of semantic elements will make HTML more readable and accessible.
- Well structured.
- I think white was a better choice for button text when not :hover or : focus. But not bad. There is readability issue with buttons on :hover and :focus. Make the text color black and it will be better.
- I feel container is a bit too small. Could make it bigger. A width: 80% or 90% for mobile and a max-width will do good. Good luck bro..
0 @bossthekhani
Submitted
nikhilka2305• 50@nikhilka2305
Posted
Good one. But I think a few improvements could be made if you want it to look closer to the provided design.
- The solution didn't use semantic HTML elements. The code will be more readable if semantic elements are used.
- Accessibility issues can be resolved if semantic elements are used.
- Lay out looks decent in all devices, but I think the card could be moved to the center for a better look.
- The code structure is good, but I think using semantic elements will improve it and make it more readable and reusable.
- There is noticeable difference from the provided design.
-
The card is not in the middle. Using margin: auto can help.
-
Box shadow is not like in the design and the white background doesn't look that well.
-
The attribution section looks accidentally added without any name or details.
-
The text font and stylings look different.
-
There is no hover / focus effects for the card.
Good luck brother.
0- Edmar Paulino• 70
@edmarpaulino
Submitted
nikhilka2305• 50@nikhilka2305
Posted
Well Done.
- Used Semantic HTML and structured well.
- Accessible and nothing comes to my mind in terms of improvement.
- As a static website, it looks good on different screen sizes.
- Very well structured, readable code.
- The solution is very close to the design.
Marked as helpful
0
