@i-oneeSubmitted over 1 year ago
Nikhil Bhaladhare
@nikbhaladhare2104All comments
- @caner404Submitted 5 months agoWhat are you most proud of, and what would you do differently next time?
Focus on accessiblity Integrating 3rd Party Library react-toastify
What challenges did you encounter, and how did you overcome them?Hanling Forms with custom components can be tricky
What specific areas of your project would you like help with?All Feedback is welcome
@nikbhaladhare2104Posted 5 months agoLooks great but can add some styling to the components. Also, some fields are already dark at the load time. So, maybe make them all dark or all white to be able to have consistency.
0 - @takinabradleySubmitted 6 months agoWhat are you most proud of, and what would you do differently next time?
I think the organization of my components in this project is pretty good, and I'm proud of that.
I had to add my own JS for the details elements to only open one item at a time on FireFox, since it doesn't support the "name" attribute on details elements it seems. I'm sure the JS I used makes the page less accessible, and I'd like to know how to rectify that.
What challenges did you encounter, and how did you overcome them?The background image was tricky until I realized two different ones were provided. Once I realized that it was pretty easy to use a media query to switch between the two background images.
If I weren't as experienced, I'm sure using pseudo-elements for the FAQs heading and the buttons would have been a bit tricky for some.
What specific areas of your project would you like help with?I'd like to know how to manage accessibility when JS is involved and showing/hiding content on screen when users click things.
- @mrcordovaSubmitted 6 months agoWhat are you most proud of, and what would you do differently next time?
I like how close it looks like to the given design.
What challenges did you encounter, and how did you overcome them?None.
What specific areas of your project would you like help with?Any general feedback is welcomed.Anyone know how to get the submit text to look like the design text has it?
@nikbhaladhare2104Posted 6 months agoHi, Maybe you can use letter-spacing to attain the desired result but i dont think that should matter here. Both looks almost similar and you can take the extra time to maybe try different things like, rather than using label and input field, use div and get the value of the div (for rating s ) to be active and so on. Overall , looks great and keep it up .
Nikhil
1 - @anderutanSubmitted 7 months agoWhat are you most proud of, and what would you do differently next time?
try to implement it with react hook form, but current case not sure how to use react hook form to trigger on-time update when type in number. Next time if app require update on time then maybe should use ori react form.
What challenges did you encounter, and how did you overcome them?- input field doesn't update on time.
- reset button no reset tip amount and total amount.
- next time need to try ori react form first
Need more practice of react hook form
@nikbhaladhare2104Posted 6 months agoEverything looks great. Some tips from my side: 1. Use map (array of numbers, ex: [5,10,15,25,50]) when creating the tip button container as it will make you write less code 2. It didnt have the submit button there. Maybe try using Context hook from react to manage global state and change them in real time rather than getting them through props.
0 - @8bit-shawtySubmitted 6 months agoWhat are you most proud of, and what would you do differently next time?
Most proud of the styling and I will try to load json next time instead of hard coded html
What challenges did you encounter, and how did you overcome them?The switching of data was the most troubling but I used plenty of online resources.
What specific areas of your project would you like help with?None
@nikbhaladhare2104Posted 6 months agoLooks great in mobile view. But in desktop view, there are some deviations in profile card and also the "Last Week - ..." should be on new line. But overall, looks great.
0 - @iamporrrrrrrrrSubmitted 6 months agoWhat are you most proud of, and what would you do differently next time?
- @Disney-BanjeSubmitted 6 months agoWhat are you most proud of, and what would you do differently next time?
I am most proud, that I was able to create the floating component fully using the JavaScript functional programming paradigm. Additionally, for doing my best to make the component responsive.
What challenges did you encounter, and how did you overcome them?I had a small challenge with the array method, however with some research and of course, using ChatGPT I was able to come up with a solution.
What specific areas of your project would you like help with?I would love a review of my JavaScript code, if it is well written and if I managed to avoid DRY code.
@nikbhaladhare2104Posted 6 months agoI looked into js code and it looks fantastic. Adding of classes using js is a smart idea. dotted border looks unique and feels authentic. Mobile first approach is a good way to solve this. overall, good. Keep it up!
Marked as helpful0 - @ajkun55Submitted 7 months agoWhat are you most proud of, and what would you do differently next time?
The grid layout is unbalanced and I have not met before, and I designed the work well.
What challenges did you encounter, and how did you overcome them?The Grid area knowledge is in details, I serached the basic tutorial doc and computed the correct ratio.
What specific areas of your project would you like help with?This is a good project.
@nikbhaladhare2104Posted 7 months agoLooks great. I liked the mobile first approach. It makes building the project much easier compared to desktop first appproach. Keep it up!
0 - @bialasssekSubmitted 7 months agoWhat are you most proud of, and what would you do differently next time?
the use of grid template areas for this layout
What challenges did you encounter, and how did you overcome them?.
What specific areas of your project would you like help with?.
@nikbhaladhare2104Posted 7 months agoLooks really great and use of grid layout is smart. I have point for you to consider, when we try to shorten the screen size (from 1440px - 1020px- 720px - 480px- 360px), the cards section deosnt wrap itself and just stays there. You can use the wrap property for this. Otherwise, looks great.
Marked as helpful0 - @PraanshuuSubmitted 7 months ago@nikbhaladhare2104Posted 7 months ago
Looks good and added effect of shadow is brilliant. In mobile view though, you did not set the width to 100% so that it would take all the width available. But overall , a good design. Keep it up!
Marked as helpful1 - @DevCris5Submitted 7 months agoWhat are you most proud of, and what would you do differently next time?
de poder completar este desafió y de que pude lograrlo
What challenges did you encounter, and how did you overcome them?al momento de ajustar el texto en el tiempo de cocción
What specific areas of your project would you like help with?en cualquier parte, gracias :)
@nikbhaladhare2104Posted 7 months agoHi, I like the new background color even if it is not the desired color. One thing to be pointed out, bullet points and ol >li numbers should be of the colors rather than black. The spacing looks much better compared to the original design.
Keep it up! 👍
0
