Skip to content
OverviewSolutions
7
Comments
4
Umair Shah
@nicefellow1234

All comments

  • Eugenia Antonova•400
    @EugeniaAntonovaSubmitted 12 months ago

    Hello! I am ultra newbie thus any comments are valuable! But here are some questions, that bother me the most:

    1. what would you do to make this component more accessable?
    2. what would you fix in my markup to make it more semantic?
    3. how would you organize here js better?

    As the project is not big at all, I would be gratefull for anyone to check it out and tell me what should I do better in future projects

    Responsive results component with dynamycly added data (html,css,js)

    1
    Umair Shah•210
    @nicefellow1234Posted 12 months ago

    You have simply not made any work in there. Please complete the challenge and then submit the solution.

    0
  • Umair Shah•210
    @nicefellow1234Posted 12 months ago

    Please make a good effort to completely match with the design 100%. Make sure to match colors as well.

    0
  • Umair Shah•210
    @nicefellow1234Posted 12 months ago

    You have made a good effort and I would like to commend you for that but I believe you can improve it further. Please make your best effort to match it with the design 100%.

    Also make sure to take a look at the style guide so that you can take hints from there to be able to get things right.

    Marked as helpful
    0
  • Umair Shah•210
    @nicefellow1234Posted 12 months ago

    This is nowhere near the design. Please learn HTML & CSS properly and make sure that your solution matches 100% the design. These two are completely different from each other.

    1