P
shpokas270• 110
@shpokas270
Submitted
nbs-ngao
@nbs-ngao
All comments
- nbs-ngao• 60
@nbs-ngao
Posted
Try including semantic HTML main for example. There some difference on font weight, colors and the last section
0 - Tharun_S_I• 30
@tharunsi
Submitted
nbs-ngao• 60@nbs-ngao
Posted
The solution include semantic HTML you can improve some points on the css : font family, border radius and white color (take the given one on the style guide)
Marked as helpful
0 - Luis Gomez• 20
@lgomez92
Submitted
nbs-ngao• 60@nbs-ngao
Posted
Your code include semantic HTML but it differ a lot from the design. It seems unfinished. Some errors (mix h1 and h2 tags for example)
0 - Journey-Grinder• 150
@Journey-Grinder
Submitted
What are you most proud of, and what would you do differently next time?
so i recently learned or knew about positions, from a video, but didn't apply them, So in this Challenge, I wanted to use them to practice them, But then I encountred a problem. Which is when you try to position an element like in my case in the center. You ll use top 50% , left 50%, But the problem here is that the origin of positioning is the pixel that is in the top left corner, so the element isn't centred in the center. That's why i searched for how I can fix this problem and yeah, I found the translate property which can translate an element, and letting it s origin to be fixed. I could say that I am proud of building a clean project, But the most thing that I am proud of. Is learning the fundamentals of git and git hub, that were really hard to deal with at first.
What challenges did you encounter, and how did you overcome them?
Figuring out how to use git and github for this project, My folder name contained spaces, and the system was pointing at it. But that folder had a sub folder which Front end Mentor told me install. So i couldn't choose it because of the spaces in my folder name, I took so much time setting up eveything, Learning git. And that's it.
What specific areas of your project would you like help with?
Responsivness.
- I m trying to work on my positioning skills.
- But I should also focus on responsivness aswell. Even though I still didn't get into it.
nbs-ngao• 60@nbs-ngao
Posted
Hi @Journey-Grinder great job few suggestions :
Try using tags main and footer instead of div if make sense.
It's best practice linking Google fonts directly in the HTML head section rather than directly in your CSS file as it enables asynchronous downloading, improving page load times.
Hope this helps
0
