Skip to content
OverviewSolutions
5
Comments
4
Nicholas Ainsworth
@nainsworth

All comments

  • Nicholas Ainsworth•50
    @nainsworthPosted 4 months ago

    Everything is well-structured and organized. Keep up the great work/1

    0
  • Nicholas Ainsworth•50
    @nainsworthPosted 4 months ago

    Everything looked very well structured, readable, and organized.

    Here's a couple of things I would add/change:

    • Would make HTML have a height of 100vh, change the body from grid to flex and center justify-content and align-items, and remove the 50px margin from the body. This would center your project to any device screen.
    • Adding css variables to :root, would allow your reused set colors and other styles consistently and make things much easier for readability and usability.

    Overall great work! Keep it up!

    1
  • Lokesh•50
    @lokeshhansSubmitted 4 months ago
    What are you most proud of, and what would you do differently next time?

    good

    Responsive page by CSS

    2
    Nicholas Ainsworth•50
    @nainsworthPosted 4 months ago

    Only a few critiques. HTML should be divided into more divs to help organize code. This would also benefit in readability, maintenance, and styling. CSS is well-organized and easy to read. I would suggest more use of Flexbox to help make styling easier and more responsive overall. Otherwise great work!

    0
  • Noor Muhammad Raza•90
    @noormuhammadrazaSubmitted 5 months ago
    What specific areas of your project would you like help with?

    I would like to get help about responsive design and writing cleaner and minimalistic css

    QR Code Component

    2
    Nicholas Ainsworth•50
    @nainsworthPosted 5 months ago

    HTML and CSS are clean and well-structured. Great job on including CSS resets and media queries. The only thing I would suggest is organizing CSS a little differently by having the .qrcode, h1, and p styling above the media queries. Otherwise, great job, and keep up the great work!!!

    0