@achrustowskiSubmitted over 2 years ago
What did you guys find difficult in this project?
How did you approach setting the display?
Cheers!
mubizzy
@mubizzyAll comments
- @mubizzyPosted over 2 years ago
Excellent job on this challenge! your report has a few issues though:
- wrap everything in your body in
<main>or use semantics
<a href=# class=ff-primary fs-100 fw-primary-regularremove thebuttonelementHope it helps:).
Marked as helpful1 - wrap everything in your body in
- @RafiiMahmudRiizviiSubmitted over 2 years ago
Please feel free to share your opinions about my coding. Your comments really help me to improve my skills.
@mubizzyPosted over 2 years agogood job @RafiiMahmudRiizvii just need need to some features for the card to be in the right position
.container{ align-items: center; justify-content: center; }Also, you need to work on your accessibility wrap your code in your
<main>Tag1 - @DhabiriSubmitted over 2 years ago
I didn't really know where the JavaScript was needed, I just started learning JavaScript and I don't really know how to use it on the page. But I did an onclick function with the div containing number 4 to style it when clicked upon .
@mubizzyPosted over 2 years agonice job @Dhabiri I must say using a two-page for your card component is not the best practice.
A page is enough you just need to understand the event listener for this part of the project.
Also, you need to work on the semantic enclose your code in a
<main>tagMarked as helpful0 - @ZoruaqSubmitted over 2 years ago@mubizzyPosted over 2 years ago
nice job @Zoruaq but you still need to work on your accessibility issues.
- you should add
alt = " "to your<img>tags`
<img src="images/icon-sedans.svg" alt = " "> <img src="images/icon-suvs.svg" alt = " "> <img src="images/icon-luxury.svg" alt = " ">hope it helps :)
Marked as helpful1 - you should add
- @blessingOluwapelumiSubmitted over 2 years ago
What did you find difficult while building the project? I was not able to use the arrow icon beside the main menu. I couldn't get how to make it change to the arrow down on hover.
Which areas of your code are you unsure of? The media queries
Do you have any questions about best practices? Please, how do I make use of the arrow down and arrow up icon and also make it interchange on HOVER?
@mubizzyPosted over 2 years agonice work @blessingOluwapelumi you did a great job. about the hover features, you need to rotate the icon using CSS properties for Example.
.dropdown:hover .dropdown__icon { transform: rotate(180deg); } .dropdown__icon { transition: .5s; }hope it helps :)
0 - @ronniiii-iSubmitted over 2 years ago
- @jahanzaibiqbalSubmitted over 2 years ago@mubizzyPosted over 2 years ago
Excellent job on this challenge! your report has a few issues though:
- wrap everything in your body in
<main>or use semantics
2. it is a best practice to use both HTML 5 and ARIA landmarks to ensure all content is contained within a navigational region.
Hope it helps:)...don't forget to mark it as helpful 👍
You can get more details here...click here
0 - wrap everything in your body in
- @ania221BSubmitted over 2 years ago@mubizzyPosted over 2 years ago
Excellent job on this challenge! your report has a few issues though:
- wrap everything in your body in
<main>or use semantics
2. it is a best practice to use both HTML 5 and ARIA landmarks to ensure all content is contained within a navigational region.
Hope it helps:)...don't forget to mark it as helpful 👍
You can get more details here...click here
Marked as helpful0 - wrap everything in your body in
- @ZyruksSubmitted over 2 years ago@mubizzyPosted over 2 years ago
Excellent job on this challenge!
Hope it helps:)...don't forget to mark it as helpful 👍
0 - @lakshithapereraSubmitted over 2 years ago@mubizzyPosted over 2 years ago
Excellent job on this challenge! your report has a few issues though:
- wrap everything in your body in
<main>or use semantics
2. it is a best practice to use both HTML 5 and ARIA landmarks to ensure all content is contained within a navigational region.
Hope it helps:)...don't forget to mark it as helpful 👍
You can get more details here...click here
Marked as helpful0 - wrap everything in your body in
- @joanFaseDevSubmitted over 2 years ago
Hello everyone!
First and foremost, english isn't my first language so please forgive me for any mispellings or grammatical errors.
I'm an aspiring front-end developper and i'd like to ask some precisions about accessibility from more experienced devs. More precisely, what is the minimum 'level' of accessibility we, as developpers, are supposed to provide nowadays. I know that semantic markups and aria landmarks are often mentionned and i tried to include them the best i could in that project but i wondered if there was something else. Maybe rules, methodologies or specifications. Something, a document maybe, developers could keep coming to when working on projects to help them make their products more accessible / more pleasant to use. I'm sorry if i'm not clear enough but accessibility seems to be mandatory nowadays and i think it's important to me as a fresh developper to understand and integrate its rules in my work as soon as possible. Thanks for reading that and happy coding to all of you!
@mubizzyPosted over 2 years agoExcellent job on this challenge! your report has a few issues though:
- wrap everything in your body in
<main>or use semantics
2. it is a best practice to use both HTML 5 and ARIA landmarks to ensure all content is contained within a navigational region.
Hope it helps:)...don't forget to mark it as helpful 👍
You can get more details here...click here
0 - wrap everything in your body in
- @NaskyiSanSubmitted over 2 years ago@mubizzyPosted over 2 years ago
Excellent job on this challenge! your report has a few issues though:
- wrap everything in your body in
<main>or use semantics
2. it is a best practice to use both HTML 5 and ARIA landmarks to ensure all content is contained within a navigational region.
Hope it helps:)...don't forget to mark it as helpful 👍
You can get more details here...click here
0 - wrap everything in your body in
