@marcfrancissSubmitted about 2 months ago
Mateus Lima
@mts-mlAll comments
- @mts-mlPosted about 1 month ago
Hey!
Nice project!
Does the solution include semantic HTML? Yes
Does the layout look good on a range of screen sizes? Yes
Does the solution differ considerably from the design? A little, somethings are a little off, like the blue background, differs from the design and logo color is different too.
It's a nice project, well done!
0 - @1deadjoeSubmitted about 2 months agoWhat are you most proud of, and what would you do differently next time?
I a proud that I was able to style the webpage without layout breaking. Although it took me quite a while. I have gotten a great grasp on transitions too.
What challenges did you encounter, and how did you overcome them?The only challenge I have encountered was trying to add in a slide in animation for the three slides. I eventually resigned, but I am still learning.
What specific areas of your project would you like help with?I hope someone could help me understand how to include the slide-in animation to my webpage. I would higly appreciate any thoughts. On the animation, and also how to go about understanding the JS involved.
@mts-mlPosted about 2 months agoHey @1deadjoe!
I like how there are no "empty" spaces when switching between different screen sizes. Did you read an article or was it just practice?
Also, I liked the arrow transition you made.
At width: 950px, the design breaks, the title and image get messed up.
As for the JS, I named all sections with the same class and used
document.querySelectorAll('.menu__bg')to select them all. Since it returns an array, I used forEach() to loop through and select the correct one to display. I'm happy with how my JS turned out, and if you'd like to check it out, I believe it could help you.Marked as helpful0 - @AZZAM-KSubmitted 2 months ago@mts-mlPosted about 2 months ago
Hey!
Nice design.
Does the solution include semantic HTML? Yes
In my opinion you should add some
transitioneffects, really improves hovers effects and the visual experience.0 - @srijanssSubmitted 2 months agoWhat are you most proud of, and what would you do differently next time?
- I learned how to use BEM methodology for CSS.
@mts-mlPosted about 2 months agoGreat solution, it looks identical!
Nice job! ;)
To be picky, you should've used
cursor: pointer;when hovering over the image. Aside from that, everything is great.Marked as helpful1 - @olopcodesSubmitted 7 months agoWhat specific areas of your project would you like help with?
Might not be the cleanest/dryest code, but it's a work in progress
@mts-mlPosted 2 months agoHey @olopcodes!
Really liked you design, the option to select between two themes is pretty nice, great job!
Does the solution include semantic HTML? No, only
<div>used and no<label>or<h1>.Does the layout look good on a range of screen sizes? Yes, it does.
0 - @salomasikSubmitted 2 months agoWhat are you most proud of, and what would you do differently next time?
I enjoyed making the responsive for this app the most, next time I want to use REACT for this app.
What challenges did you encounter, and how did you overcome them?Displayed design for tablets.
What specific areas of your project would you like help with?I want to hear suggestions on working with js frameworks.
@mts-mlPosted 2 months agoHey @salomasik!
I also want to recreate this challenge using React, I believe it's going to be a good experience using props, useEffect()...
The feedback: Your solution looks good, needed to change the font family to the correct one. The gap between cards is larger than in the provided solution, and on mobile screens, it's not centered.
The HTML is semantic and the solution is responsive.
Marked as helpful0 - @juliusalbertoSubmitted 4 months agoWhat are you most proud of, and what would you do differently next time?
I am most proud of creating the js script! I learnt how to manage events and change element class. I would do it faster next time (although I think mine is alr fast enough).
I also created this using a mobile-first workflow. Surprisingly, it's kinda fast!
What challenges did you encounter, and how did you overcome them?I don't encounter any difficult one, but I think it's lining up the padding and margin. And responsive design. My website looks ugly on tablet.
@mts-mlPosted 2 months agoHey @juliusalberto!
Nice design, looking at yours I realized I didn't change the standard e-mail from mine, got to correct it...
For feedback, two things, the HTML is not semantic, you should use at least a
<main>tag instead of only<div>. And in my opinion, I'd change the message when the e-mail is valid and the field color.0 - @gajbos99Submitted 4 months agoWhat are you most proud of, and what would you do differently next time?
/
What challenges did you encounter, and how did you overcome them?/
What specific areas of your project would you like help with?Well i ran into a couple problems. first of all. i created mobile first and created the design for both of the share parts. i just do not know how to change that when full screen as that is looking different. the mobile social media icon div is looking different from the one on the desktop. What is the best way to do that? as now i put display none on the light share bar and display flex on the other one and that toggles. but on the desktop version the light one doesnt need to be removed.
@mts-mlPosted 2 months agoHey @gajbos99!
I liked that you used React and useState. I've used JS to manipulate the class, but using the hook seems better.
I tried to preview the solution site but got a 404 error. Looking at the code, I noticed that you jumped from a <h1> to a <h4>. I've read that you should always follow header hierarchy.
The solution differs a little from the design; the background color is off, and the name/date is centered when it should be aligned to the left.
About your question, I’d need to see the page and play around with it a bit to try and provide some input.
0 - @wideirpSubmitted 3 months ago@mts-mlPosted 3 months ago
Hey!
Great job overall! Everything looks pretty good, aside from some color differences. The HTML and CSS are well done, and it's responsive too.
Nice work!
0 - @deidalopezSubmitted 3 months agoWhat are you most proud of, and what would you do differently next time?
Getting the initial scaffolding done.
What challenges did you encounter, and how did you overcome them?I needed more grid practice, the heading was a struggle for me for some reason.
@mts-mlPosted 3 months agoHey @deidalopez!
Congratulations on finishing the challenge, I've had some trouble with this one too, had to learn grid in order to get the cards right.
I liked how you've configurated you CSS, I didn't know you could use
$red: hsl(0, 78%, 62%);. Gotta check this out.Does the solution include semantic HTML? I've noticed you used
<h1>and then jumped to<h3>, it's recommended to follow the headers hierarchy.Does the layout look good on a range of screen sizes? On mobile screens the header doesn't appear.
0 - @PriyaSharma026Submitted 3 months agoWhat are you most proud of, and what would you do differently next time?
I am proud of that I could make a responsive project without watching a youtube tutorial and figuring out things by my own and this time I used Sass extension for the first time and I loved it.
@mts-mlPosted 3 months agoGreat design, looks exactly like the prototype.
Great job!!!
1 - @Jaimealicante83Submitted 3 months agoWhat are you most proud of, and what would you do differently next time?
I built it with attention to the detail and measures of the design. It's the kind of work I do at my workplace.
What challenges did you encounter, and how did you overcome them?This template was more difficult than the previous one, I had to pay attention to the details
What specific areas of your project would you like help with?How to avoid mistakes while building the template and be aware of errors.
@mts-mlPosted 3 months agoHey Jaime!
Excellent work, the design looks very nice.
I have no comments, just congratulations!!!
Marked as helpful0
