Moses
@mtenkorangAll comments
- @chandan9369Submitted about 2 years ago@mtenkorangPosted about 2 years ago
Congratulations and here are a few ways to improve your code. The third accessibility warning has to do with semantic html tags. This is a link to an article on w3schools.
- Instead of using
<div class="container">
, opt for<main class="container">
- Instead of
<div class="card-text"> Discover the benefits of data analytics ... </div>
opt for
<div class="card-text"> <p> Discover the benefits of data analytics ... </p> </div>
- Instead of using
<div class='attribution'>
, opt for<footer class="attribution">
I hope this helps and happy coding .🙂👨💻
0 - Instead of using
- @iscanabdulhalikSubmitted about 2 years ago@mtenkorangPosted about 2 years ago
Congrats on attempting this challenge. Here are a few ways to improve your solution;
-
Instead of putting text in a div tag only try to use semantic tags like headings and paragraphs in this solution. Visit this link to read more about it on w3schools.
-
Also, you can add the tailwind classes for the styling below,
{ flex-direction: column; align-items: center; text-align: center; }
to the parent element of the following
<div> <p>10k</p> <p>Companies</p> . . . <p>Queries</p> </div>
to make them look close to the design for mobile.
All the best and Happy Coding .👨💻🙂
Marked as helpful0 -
- @alexbrudascaSubmitted about 2 years ago@mtenkorangPosted about 2 years ago
- You can put the class="attribution" in a <footer> tag to pass the accessibility report warning.
- I will recommend you use rem or px(pixel) values for setting the border-radius of your buttons. I played with it in developer mode and found that the values below were suitable
.btn{ border-radius: 35px; }
or
.btn{ border-radius: 2.5rem; }
I hope this helps. Happy Coding 😁👨💻
Marked as helpful0 - @damagermaxSubmitted about 2 years ago
Though I was able to achieve the desired result, I'm not sure if I am following the best practices. Any help, criticism or feedback is welcome, I am here to learn!
@mtenkorangPosted about 2 years agoThis challenges requires the use of two images 🎑 for different breakpoints. The Picture Element should help with that.
<picture> <source media="(min-width: 650px)" srcset="img_food.jpg"> <source media="(min-width: 465px)" srcset="img_car.jpg"> <img src="img_girl.jpg"> </picture>
Marked as helpful0