All comments

• 

  Gaurav Pratap Singh• 340

  @gauravsingh1281

  Submitted almost 2 years ago

  Have a look over my code and give a suggestions on how i can improve my coding skills.

  

  Interactive rating component using HTML, CSS flexbox & Vanilla JS.

  1

  20

  

  mrxshinji• 370

  @mrxshinji

  Posted almost 2 years ago

  For your alert code, it is better not to touch innerText with js whenever possible in my opinion. Its like all the changes in structure should keep in html, script changes in js, and stylechanges in css .

  I would use css {display: none} and {display: block} to show the text by adding active class instead.

  <p id="alert">"Please select a number"</p>
  

  #alert{
    display: none;
  }
  
  #alert.active {
    display: block {
  }
  

  document.querySelector("#alert").classList.add("active")
  

  This should be the way to write this....

  Marked as helpful

  0
• 

  mrxshinji• 370

  @mrxshinji

  Submitted about 2 years ago

  *Still having trouble of handling responsiveness without getting stuck from time to time.

  *Not sure did I make my navbar react too complicated?

  

  Intro with dropdown navi using react

  1

  10

  

  mrxshinji• 370

  @mrxshinji

  Posted about 2 years ago

  ...I accidentally miss login and register button, to add later...its 6am here now...

  0