All comments

• 

  denisejy• 10

  @denisejy

  Submitted almost 2 years ago

  Hi! This is my first time using Tailwind CSS for styling. I would appreciate any feedback given to improve my code.

  And things I would like to know and learn:

  1. Are there any good practices when it comes to placing a div or card at the center of a page?
  2. Is there anyway to show my footer attributions without scrolling?

  Thank you for any feedback and comments given!

  

  QR Code Component using Tailwind CSS

  1

  60

  

  Oussama Moutafatin• 380

  @moutafatin1

  Posted almost 2 years ago

  Yo, Good job on completing this challenge.

  1 - for the first question, it depends, some times I just "flex justify-center item-center" and other times I center with a margin left and right auto.

  2- To show your footer without scrolling, you should change the height of the div holding the card to a value lower than 100vh, because the div takes the whole view, adding more height and will show the scroll, Or maybe you can wrap the div and the footer into another div and make the height of that div 100vh.

  finally, try to fix the accessibility and HTML validation error, adding a lang attribute to the HTML tag and changing the div tag holding the card to the main tag, as you do in the footer using, search for semantic HTML for more info.

  Sorry for my English and have a good day.

  Marked as helpful

  1

  This comment has received 1 replyShow