MortalCoder
@mortalcode
All comments
- MortalCoder• 180
@mortalcode
Posted
Hey Adetolar, Great work with the project, it's good to see you working with display grid, But in simple center container websites, I have always found flex work for me and its quite easy to setup container and objects in the center of the main body. It's best to know both. hope you find this helpful, Happy Coding!
0 - Kebede Assefa• 40
@zebse
Submitted
MortalCoder• 180@mortalcode
Posted
Hey zebse, Great attemp only you have to center your container you can use, "display:flex" also set align-items and justify-content to center your container. hope you find it usefull, happy coding!
0 @KshitijKhandelwal-Github
Submitted
MortalCoder• 180@mortalcode
Posted
Hey Kshitij Khandelwal, if seems that when you upload the files to github you upload it in a folder (best practice is to drag and drop the contents of a folder that you have kept all of the files in) or you have not specified you main html files as "index.html", which is causing you code to run properly. hope you find this helpful, happy coding
0- Surya Prakash Singh• 170
@suryathink
Submitted
MortalCoder• 180@mortalcode
Posted
Hey Surya Prakash Singh, Great job with your code, you just have to fix you media queries the rest will work as you intended. for example="@media only screen and (min-width: 1px) and (max-width: 720px) {}"
Secondly, you don't have to specify the all the properties as by default the are "normal", you only specify or target them when you want to change it, example as follows, (your code)
.hero-content button { font-family: Montserrat; font-size: 14px; font-style: normal; <-- font-weight: 700; line-height: normal; <-- } hope you find this helpful happy coding!
Marked as helpful
1
