morteza
@mooryxAll comments
- @Rajiv-0920Submitted over 1 year ago@mooryxPosted over 1 year ago
congrats on completing this challenge .
I geuss you forgot to make the button interactive and add icons
except that everything looks great.
Marked as helpful0 - @mooryxSubmitted over 1 year ago
- @ahoin001Submitted over 2 years ago
I do wonder how you guys get things more pixel perfect. But I think I achieved all the goals of the challenge
@mooryxPosted over 2 years agocongrats on completing this challenge
you can use perfect pixel extension (chrome) and put design images on the browser screen and compare them with your design.
or you can buy premium and get figma and sizes.
I hope that can help you
happy coding :)
Marked as helpful1 - @R1lothSubmitted over 2 years ago
Hello, while building this I used grid which I'm absolutely new to, and I found it difficult to shift the layout from mobile first to desktop so if you have any recommendations about using the grid and queries better way please let me know, also I don't like the responsiveness while I resize the viewport any tips how I could do it better would be great.
@mooryxPosted over 2 years agocongrats on completing this challenge.
about responsiveness, you used fixed size for your .wrapper class
and body tag does nothing in your code
I already made a few changes to your code. you can accept my pull-request and see what I've changed I hope that can help you.
besides that everything looks good
Marked as helpful2 - @javamercySubmitted over 2 years ago@mooryxPosted over 2 years ago
hey good job completing this challenge
one thing to mention is buttons are not interactive you can add that by
button:hover { styles }
good luck
0 - @besttlookkSubmitted over 2 years ago
These are my early days of using typescript . If you find any bug or have any suggestion do let me know.
Feedback makes us a good developer. So keep them coming...
Thanks,
#happyCoding
@mooryxPosted over 2 years agoyour solution looks great
I want use your code as a reference for my code but I didn't learn ts and scss yet so I'm not sure I could understand your code.
- I want to know how did you animate the toggle button?
keep up the good work
1 - @pyko7Submitted over 2 years ago
There is my solution for this challenge, I hope you like it and I will be waiting for your feedback. If you have any advices about my code please let me know ! 😀
- @khantmhtooSubmitted over 2 years ago@mooryxPosted over 2 years ago
good job completing this chalenge one thing too mention is buttons are'nt interactive to do that you can change background-color and text-color on hover state (button:hover{ // styles } )
Marked as helpful0