All comments

• 

  sudhan333•10

  @sudhan333Submitted over 1 year ago

  

  Qr-Code-Component

  2

  80
  

  md_mark•180

  @mohdahsanrazakhanPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge!

  I have recommendations regarding your code.

  You should add lang="en" attribute inside your html tag to improve accessibility and organization of your page.

  I hope you find this helpful.

  Happy coding!

  0
• 

  Eivan•50

  @eivanliongsonSubmitted over 1 year ago

  My solution to the NFT Component Preview

  Did it similar to the design. Bummed because I can't figure out how to do the hover effect. Maybe someone could help me figure it out.

  

  NFT Component Preview

  1

  60
  

  md_mark•180

  @mohdahsanrazakhanPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge!

  I have recommendations regarding your code.

  You should write _blank instead of just _ or remove your target attribute. But the best practice is to use target="_blank" inside your a tag.

  I hope you find this helpful.

  Happy coding!

  1
• 

  Hadi Farbakhsh•40

  @HadiFarbakhshSubmitted over 1 year ago

  Hi, I'd be happy to have your comments on how to change the cursor type to be exactly like the challenge. Thankful

  

  Frontend Mentor-NFT preview card component solution using HTML and CSS

  1

  60
  

  md_mark•180

  @mohdahsanrazakhanPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge!

  I have recommendations regarding your code that I believe it will great interest to you.

  HTML: This solution generates accessibility error reports. So fix it by one h1 tag inside your <article class="name"> tag and inside <section class="description"> bound the content inside h2-h6 tag or p tag in your index.html file to improve accessibility and organization of your page.

  I hope you find this helpful.

  Happy coding!

  Marked as helpful

  0

  This comment has received 2 repliesShow
• 

  vanamos12•10

  @vanamos12Submitted over 1 year ago

  How to center a box vertically?

  

  Simple css flex solution

  4

  80
  

  md_mark•180

  @mohdahsanrazakhanPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge!

  I have recommendations regarding your code that I believe it will great interest to you.

  HTML: This solution generates accessibility error reports. So fix it by replacing the <div class="main"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

  You should add one h1 tag inside your main tag and add alt="QR code image" attribute inside <img src="images/image-qr-code.png">

  In place of <div class="attribution"> you should use footer tag.

  I hope you find this helpful.

  Happy coding!

  Marked as helpful

  1
• 

  ichimon-nashi•120

  @ichimon-nashiSubmitted over 1 year ago

  

  Responsive QR code using CSS flexbox

  1

  30
  

  md_mark•180

  @mohdahsanrazakhanPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge!

  I have recommendations regarding your code that I believe it will great interest to you.

  HTML: This solution generates accessibility error reports. So fix it by replacing the <div class="box-outer"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

  You should add one h1 tag inside your main tag and add alt="QR code image" attribute inside <img src="images/image-qr-code.png">

  In place of <div class="attribution"> you should use footer tag.

  I hope you find this helpful.

  Happy coding!

  Marked as helpful

  0
• 

  BK Madsen•60

  @MadsenBKSubmitted over 1 year ago

  I dont have any specific questions for this challanege however any general feedback or errors Ive missed would be appreciated. Thank you!

  

  QR Code Component

  1

  50
  

  md_mark•180

  @mohdahsanrazakhanPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge!

  I have recommendations regarding your code that I believe it will great interest to you.

  HTML: This solution generates accessibility error reports. So fix it by replacing the <div id="mainContainer"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

  Replace h2 tag to h1 tag inside your main tag and add alt="QR code image" attribute inside <img src="images/image-qr-code.png">

  In place of <div class="attribution"> you should use footer tag.

  I hope you find this helpful.

  Happy coding!

  Marked as helpful

  1
• 

  SorinSr4•60

  @SorinSr4Submitted over 1 year ago

  

  QR-Code-Component using HTML and CSS

  3

  60
  

  md_mark•180

  @mohdahsanrazakhanPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge!

  I have recommendations regarding your code that I believe it will great interest to you.

  HTML: This solution generates accessibility error reports. So fix it by replacing the <div class="container"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page. You should replace h4 tag to h1 tag inside your main tag.

  I hope you find this helpful.

  Happy coding!

  Marked as helpful

  0
• 

  Umer Sohail•80

  @callmeUmerSubmitted over 1 year ago

  

  QR component in Vanilla HTML and CSS

  1

  20
  

  md_mark•180

  @mohdahsanrazakhanPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge!

  I have recommendations regarding your code that I believe it will great interest to you.

  HTML: This solution generates accessibility error reports. So fix it by replacing the <div class="container"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page. Add alt="QR code image" attribute inside <img src="images/image-qr-code.png" width="256">

  I hope you find this helpful.

  Happy coding!

  Marked as helpful

  0

  This comment has received 1 replyShow
• 

  Mahesh Paul•30

  @CityIsBetterSubmitted over 1 year ago

  

  Qr code component using HTML and CSS

  1

  30
  

  md_mark•180

  @mohdahsanrazakhanPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge!

  I have recommendations regarding your code that I believe it will great interest to you.

  HTML: This solution generates accessibility error reports. So fix it by replacing the <div class="container"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page and replace the <div class="attribution"> element with the semantic element <footer> in your index.html file. Add alt="QR code image" attribute inside <img src="./images/image-qr-code.png">

  I hope you find this helpful.

  Happy coding!

  1