Wouter Bus• 270
@wouterbus
Submitted
mohad12211
@mohad12211
All comments
- mohad12211• 70
@mohad12211
Posted
Add some margin at top and bottom of the page. Try to use the proper fonts in the headings
0 - ariadna64• 20
@ariadna64
Submitted
What specific areas of your project would you like help with?
I'd like help with the general HTML structure, the lateral padding of the main card and how to make it look good for mobile. Everything else I believe is fine.
mohad12211• 70@mohad12211
Posted
You can add a max-width property to fix the main div Try to apply the fonts that's given in the project
Marked as helpful
0 - Lampros Liontos• 100
@reteov
Submitted
What are you most proud of, and what would you do differently next time?
I'm getting the hang of writing the HTML so that the flexboxes can be configured for correct spacing. I am also using
*, and:rootfor items I expect to exist throughout the document, as well as@font-faceto add the custom fonts.What challenges did you encounter, and how did you overcome them?
The big challenge is still getting the hang of using Flexboxes so that there are containers in which to position page elements; I'm still bumping into too many cases where I forget to add a container, and then wonder why an element won't center (vertically or horizontally).
I'd like to say I had an aha moment, but at this time, it's just good, old-fashioned practice, practice, practice!
What specific areas of your project would you like help with?
At the moment, it's too early to ask for help; I'm not yet out where there are difficult challenges, just silly stuff that I know the answers to, if I just step back and look for a minute.
mohad12211• 70@mohad12211
Posted
your spacing is good, but some dimensions are not the same as the figma design
0 - CJ-Cepe• 200
@CJ-Cepe
Submitted
What are you most proud of, and what would you do differently next time?
- Proud of: Implemented my first FM proj, Yey!
- What I would do differently next time:
- Implement with CSS Grid.
- Use class names instead of nested CSS selectors.
- Use relative units instead of absolute units.
What challenges did you encounter, and how did you overcome them?
- Challenge: Making the component responsive below 375px and preventing it from overflowing the parent (body).
- Solution: Set the QR component width to 100%, and set a max and min-width.
What specific areas of your project would you like help with?
- What is the appropriate HTML element for the QR component to adhere to semantic HTML?
- Is it acceptable to use only nested element selectors, or is it better to use class selectors?
- Should responsiveness for screens smaller than iPhone SE (375px) or Galaxy Z Fold (344px) still be considered?
Thank you
mohad12211• 70@mohad12211
Posted
nice
0
