Hi! I just completed this challenge, any feedback is welcome! Thanks π
Moataz
@moataz-seragAll comments
- @wiksmfSubmitted over 2 years ago
- @correlucasSubmitted over 2 years ago
πΎ Hello, Frontend Mentor coding community. This is my solution for the Profile Card Component.
Feel free to leave any feedback and help me improve my solution or make the code clean!
π I had a lots of fun building this challenge! I changed almost all design with the FRESH PRINCE THEME
πͺ I had some issues position the circles as background so I just export the background from Figma. My bad.
I added some features:
- π¨ Custom hover on profile image using the general sibling selector.
- π¨βπ¬ Custom hover effect on profile background!
I'll be happy to hear any feedback and advice!
@moataz-seragPosted over 2 years agoHello ,lucas. nice work bro but i suggest to do a little margin in h2 , i think that will be more good . keep going .
1 - @Juned7734Submitted over 2 years ago
I found little difficulty in making responsive
@moataz-seragPosted over 2 years agoHello bro , good jop first . the difficulty because you are give every element padding and margin,but you should do it in the #div2 it will be easy to responsive. good bro keep going and i hope to be fine.
0 - @FloraBloomblueSubmitted over 2 years ago@moataz-seragPosted over 2 years ago
Hello, good jop but i have an advice for you. you can make the border lighter than you made. keep going .
Marked as helpful0 - @Budan-devSubmitted over 2 years ago
All Feedback is been welcomed
@moataz-seragPosted over 2 years agoHello, you aren't using the right font . You can find it in the style guid file ,and nice work . keep it up.
0 - @PaulaDudutaSubmitted over 2 years ago
I've had a problem with vertical alignment of the product-card for the desktop resolution. I've chosen the method with margin top and bottom to center it (I know it's not the right way:)). But my question is, how can I vertically center the product-card? Do you have any other suggestions over the way I've structured/styled the project? I'm still a newbie trying my best:)
Thank you for your answers!
@moataz-seragPosted over 2 years agoHello, paula. yes we have a lot of methodes to vertical alignment of the product-card. for instance, you can use the flexbox in the body 2-you can use the position (absolute) to the main div then use the transform (translate). Now, you are having two ways to do that choose anyone you like and search to find more. good luck to you.
1