@mkamburdev
@Girish070
Submitted
What are you most proud of, and what would you do differently next time?
...
What challenges did you encounter, and how did you overcome them?
...
What specific areas of your project would you like help with?
...
@mkamburdev
Posted
Hi 🖖,
Well done for making the design close to the original design. I think the design will be closer to the original design with a few suggestions. In your index.css file, it would be better to update the border-radius value in the ".container" class to "1.25rem". Also the h1 font-size is a bit big.
.container {
background-color: var(--White);
border-radius: 1.25rem;
box-shadow: 5px 5px 5px rgba(0, 0, 0, 0.05);
margin-bottom: 2rem;
padding: 1.25rem;
}
Hope this was helpful. Happy coding! 🤩
@R3iwan
Submitted
What are you most proud of, and what would you do differently next time?
Proud of to concentrate my power and attention to this project and after creating it, i enjoyed it so much, i love this project.
What challenges did you encounter, and how did you overcome them?
Some problems with divs and img, when it doesn't go to the center, i was angry about it xD, but i'm happy to handle this problem
@mkamburdev
Posted
Hi 🖖,
the design looks very nice and closely resembles the original, you've done a great job, congratulations. My only suggestion would be to add a border to the ".main" class in your styles.css file, line 56. I think this will make the design closer to the original, that's the only thing missing. Everything else is great.
.main {
border: 1px solid hsl(0, 0%, 7%);
}
Hope this was helpful. Happy coding! 🤩
Marked as helpful
@karishmak77
Submitted
@mkamburdev
Posted
Hi 🖖,
the design looks very nice and closely resembles the original, you've done a great job, congratulations. My only suggestion would be to slightly decrease the radius value of the .qr_code div to make it resemble the original design even more.
.qr_code {
border-radius: 1rem;
width: 100%;
}
Hope this was helpful. Happy coding! 🤩
Marked as helpful
@Y-Ismail
Submitted
What are you most proud of, and what would you do differently next time?
I was able to complete it is good
What challenges did you encounter, and how did you overcome them?
Quite a few
What specific areas of your project would you like help with?
NO areas
@mkamburdev
Posted
Hi🖖,
you've done a great job. I want to give some feedback. The border radius in the style codes you've added to the visual is a bit too much. You should reduce the radius value. Also, the color you've given to the h2 heading is not the same as in the original design. I recommend checking the style-guides file for the correct color codes.
Hope this was helpful. Happy coding! 🤩
Marked as helpful
@DaNuTzU2110
Submitted
What are you most proud of, and what would you do differently next time?
I am proud of finishing this challenge.
What challenges did you encounter, and how did you overcome them?
I didn't encounter any problem for moment.
What specific areas of your project would you like help with?
I would help with all areas because this is a simple component for beginning.
@mkamburdev
Posted
hi 🖖,
the design looks very similar to the original. It seems like a great job has been done. My only suggestion would be:
.card-text {
color: var(--grayishBlue);
margin: 20px 25px;
font-weight: 400;
max-width: 280px;
}
By adding max-width, you'll achieve an exact match with the original design, ensuring the text section's width is the same as the original design.
Hope this was helpful. Happy coding! 🤩
Marked as helpful
@TheVolky
Submitted
What are you most proud of, and what would you do differently next time?
I'm proud to use figma for this tiny project, it's the first time i use it.
What challenges did you encounter, and how did you overcome them?
I tried to do the exact same page then the figma file, but there still have tiny difference.
What specific areas of your project would you like help with?
I just want to know what i did wrong and what i can improve ?
@mkamburdev
Posted
hi 🖖,
Changing the border-radius on line 11 from 30px to 15px will make it look more like the original design.
.qrCode {
border-radius: 30px;
}
Updating the font-size on line 39 to 15px will make the text size match the original design better.
p {
font-size: 15px;
}
Hope this was helpful. Happy coding! 🤩
Marked as helpful
@Debosmita465
Submitted
@mkamburdev
Posted
Your design looks great, 😎 but the colors don't quite match those specified in your style-guide.md. I think it would be even better if you could align them more closely. Good luck with your work!
@IsaacLira42
Submitted
@mkamburdev
Posted
Everything looks great and smooth.😎 However, I'd like to give some feedback. If you use 'max-width: 100vw;' instead of 'max-width: 1440px;' in your CSS code for the body tag, the card will be aligned to the center of the page. This will provide a better look. 🖖
