Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • P
    Duy Anh Le 120

    @leanhduy

    Submitted

    What are you most proud of, and what would you do differently next time?

    Get a solution that's quite similar to the design image, without design files.

    What challenges did you encounter, and how did you overcome them?

    Handle image size to look good on different screen sizes. My current method: Using vh unit to set the height of the image until it looks good for my eye, so it's quite personal-based, without any formula.

    What specific areas of your project would you like help with?

    I'm looking for any articles / guidances about best practices when working with image size for different screen sizes. If you could provide some, I would be very appreciated.

    mircodev 60

    @mircodg

    Posted

    Hi, congrats for your submission! I think you did a pretty good job.

    0
  • mircodev 60

    @mircodg

    Posted

    Hi @alfanarifian, congratulations for your solution. I would give you some best practice tips for both html and css.

    In css is best to have a reset because any html attribute comes with default css properties. In order to be more consistent with box sizing and overall layout you can put the following code at the start of your css file:

    *{
        margin:0; 
        padding:0; 
        box-sizing: border-box;
    }
    

    If can also set the font family inside of it. Then for the html I suggest to use semantic tags like <header> , <main>, <footer>, and so on. Also try to do all the styling on the style.css and avoid doing so in the html for code readability.

    Other than that I think you did a really good job.

    0
  • mircodev 60

    @mircodg

    Posted

    Hello @sajjad8m3, congratulations on completing this challenge.

    You did a really good job, HTML it's well-structured, but lacks a bit in semantics. If you want to make it more semantic, you can, for example, use <header> and <footer> tags.

    0
  • mircodev 60

    @mircodg

    Posted

    Hi, I think you did a pretty good job. Only thing I would do is:

    1. Make the container bigger to improve readability;
    2. Use semantic html tags.

    Marked as helpful

    0