Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • P
    Fluffy Kas 7,735

    @FluffyKas

    Submitted

    Hey guys, if there's anything I could improve on, please let me know. Have a great day! :)

    Edit: I set an animation delay on my cards so they don't show up in the challenge screenshot. Is there a way to fix this?

    Mikko 15

    @mikkoo99

    Posted

    Project is well coded. Almost everything is legible (like that comments which separate sections), and good use of variables. On my 13" laptop i have to scroll down to see last card. I suggest to give your body 'height: 100vh' in '@media (min-width: 900px)'. In that case you will have to reduce size of elements.

    0
  • Mikko 15

    @mikkoo99

    Posted

    You've got error in opening your project from github. Make sure that your repository hasn't got index.html in any folder (in my case it worked after doing that)

    0
  • Mikko 15

    @mikkoo99

    Posted

    Great job! It looks well on my IP11. About code, don’t use #id for css, leave it for JavaScript, use .class for css only. You can be more specific with width of your columns by adding flex-basis: 100% in your class=„card”. Doing that you dont have to give your columns width: 33,3333…% What’s more in your media quaries you have in your .card flex-wrap: nowrap and flex-wrap: wrap

    0