Why does css consumes too much time and how can i improve??
Ibrahim Isa Jajere
@mikib0All comments
- @mikib0Submitted almost 3 years ago@mikib0Posted almost 3 years ago
@skyv26 thank you very much for your feedback. I will focus more on accessibility in my future projects.
1 - @minahilakhtarSubmitted almost 3 years ago@mikib0Posted almost 3 years ago
Hey @minahilakhtar i just viewed your solution on desktop and there is an issue with the tooltip and also the share button does not have a background.
The animation on the tooltip is great btw.
0 - @DummyKenSubmitted about 3 years ago
There are two background svgs so I don't know how to do that. Apart form that, I think this looks pretty good. Please kindly provide feedback!
@mikib0Posted about 3 years agoI also found that difficult although i somehow achieved it using
position: absolute
. But while browsing @MonaElshikh`s code i found thisbackground: url(../images/bg-pattern-top.svg) no-repeat, url(../images/bg-pattern-bottom.svg) no-repeat; background-position: right 50vw bottom 50vh, left 50vw top 50vh; background-color: var(--body-bg-color);
to be a better solution.Oh i have an observation your profile image is not centered.
I hope it helps. Have a great day!! :)
Marked as helpful0 - @MonaElshikhSubmitted about 3 years ago
Hi there, i have learned a lot from your valuable comments, will appreciate any feedback from you. Thanks :)
@mikib0Posted about 3 years agoHi @MonaElshikh, I learned alot from your work. Great project!
Marked as helpful0 - @adrianh42Submitted about 3 years ago
This took me quite a while figuring out the flexbox wrapper, and it took me 3 tries before it became responsive. I guess I'm quite proud of it haha.
Also tried to use css grids for the stats numbers but couldn't figure out how to control the grid item's width, can anyone help me on that? Thanks!
@mikib0Posted about 3 years agoI think you can do that by explicitly setting a width on the grid item.
0 - @karishma-devSubmitted about 3 years ago
Hey Guys, I just finished the 3-column Preview Card Challenge. I would like you all to see it and let me know how I can improve it. Let me know my mistakes . Thank you!.
@mikib0Posted about 3 years agoHey @Krrish105 I have a few suggestions on your project: 1. You could set
min-height: 100vh
on main to make it take up the whole height of the device it is viewed on and again setdisplay: grid; place-items:center;
on it to center the container inside it. 2. Instead of fixing a height on the card items you can let the content inside decide the height. Apart from that, great work!. I hope my feed back helps.Marked as helpful0 - @ShinobiusSubmitted about 3 years ago
I'd love to hear feedback on the quality of my code and what could be improved.
@mikib0Posted about 3 years agoHi @Shinobius
I have a few suggestions to make on your code: - I like the way you use **BEM** and I also learned from it - I suggest that you enhance the responsiveness of the site Apart from that, it is great !
0