Overall I am happy with the result
What challenges did you encounter, and how did you overcome them?Here is the slightly corrected text: It was difficult to write JavaScript code so that everything worked correctly.
Overall I am happy with the result
What challenges did you encounter, and how did you overcome them?Here is the slightly corrected text: It was difficult to write JavaScript code so that everything worked correctly.
I'm proud because this is my frist challenge using SASS preprocessor. Next time I aim explore more resources available in SASS.
What challenges did you encounter, and how did you overcome them?I was complicated using pure SASS without plugins, as Gulp-Sass, Grunt-Sass and Webpack + Sass-loader. I searched the solution on internet, but there are few content about this
What specific areas of your project would you like help with?I would like help about SASS, if I used it correctly in my solution. Thanks!
Some reason when viewing on my deskstop , the solution is not matching
I new to sass and i like how organized you have your files, could you give me some tips to how to better organize my project. and nice work on the project ! it spot on
It was an error when trying to open up the preview site ,
The biggest challenge in this project was to change style of markers in lists. MDN and Stack Overflow were helpful.
Nice project looks just like the design ! Btw any reason you didn't use the provided fonts ? you can use @font-face
to import them but besides that nice work !
I have integrated CSS variables and started using better alternatives to px.
What specific areas of your project would you like help with?When I use Tab to navigate, the glow effect is different from what I had thought. When I loaded the file for the first time, it showed me a different font, and then I switched to my font. Can the website load the font first before showing up?
You should follow semantic HTML, for example you have <div class = "links"><a href = "#" class = "links-text">Github</a></div> <div class = "links"><a href = "#" class = "links-text">Frontend Mentor</a></div> <div class = "links"><a href = "#" class = "links-text">Linkedin</a></div> <div class = "links"><a href = "#" class = "links-text">Twitter</a></div> <div class = "links"><a href = "#" class = "links-text">Instagram</a></div>
you could've did <ul><li><a></a></li></ul>
since you have a list of items
Another thing to note is to look into rems and ems instead of using px when using them for setting font-size
, widths
etc..
but besides good job !
Nice project, I learned a nice feature in css called text-wrap: balance;
and it would help balance the text you have and for better readability . Also i would decrease the thickness around the border of your card just by a little bit. But besides that good job !
img
instead of the parent container.Maybe increase the padding around your <section class="card-text"></div>
as well , and add some margin-top
between your img
, h1
, p