Michael
@mikester380All comments
- @oyeyinkaojoraSubmitted over 2 years ago
- @akaigyouhouSubmitted over 2 years ago
There are two problems I've met. 1, Is it right to first determine the "width" and "height" of the "card", then add the "padding" or "margin" to flow the inner content in the right position? 2, To make the eye icon in the middle of the Equilibrium picture and also the cyan color layer when hovering the picture. I use two layer. Because the first one should not be opacity while the second one should be half opacity. Maybe there are better solution.
@mikester380Posted over 2 years agoHey there. Congrats on completing this challenge. You don't have to set a height on the container as the margins and paddings you use as seen in the design will add up to create the overall height of the container.
0 - @ninaokumuraSubmitted over 2 years ago@mikester380Posted over 2 years ago
Hey coder! I love your solution. I think you should also hide the advice ID until the advice has finished loading before display it.
0 - @jovan-devSubmitted almost 3 years ago
How can I make my code a little better??
- @MYSTYX7Submitted almost 3 years ago
Tried responsive design for the first time. Currently only added screen size are for desktop and mobiles. Would love to hear few feedbacks. Thanks.
@mikester380Posted almost 3 years agoHey! Your design looks pretty good except for the responsive part which needs more work. Apart from the that, you did a really good job. Congrats
Marked as helpful0 - @JohnIdenyiSubmitted almost 3 years ago
Hi everyone! I'd appreciate any feedback you can give me on the design.
- @adrianh42Submitted about 3 years ago
- Is the HTML semantic correct?
- After testing in Chrome's device emulation, it doesn't seem to scale the content in the way I'd like on certain devices, like a Galaxy Fold or smaller iPhones, maybe because of the lower dpi? Is there a way to work around this?
@mikester380Posted about 3 years agoHey Adrian,
Congrats on completing this challenge. I couldn't find any problems with your design. Good work! 👍
0 - @karishma-devSubmitted about 3 years ago
Hey Guys, I just finished the Stats Preview Card Challenge. I would like you all to see it and let me know how I can improve it. Let me know my mistakes . Thank you!.
@mikester380Posted about 3 years agoHey Karishma,
Your card is not properly centered. Try removing the margin on the card container and set the body element to display: flex; and justify-content: center; to properly center the card container.
Apart from that, your solution is very impressive. Congratulations!
Marked as helpful0 - @morgan03Submitted about 3 years ago
I found this challenge quite difficult especially with the 'expand image part' where the images expand with a dark background, how the basket changes position on mobile and also putting the icon arrows in a rounded background. Would appreciate some feedback to see how other people approached it!
@mikester380Posted about 3 years agoSet a width on the container of the arrow icons and use border-radius: 50%; to make it a rounded circle
Marked as helpful1 - @pszponderSubmitted about 3 years ago
I would like to get feedback on the way I am implementing BEM and whether or not I need to correct anything in my naming convention.
@mikester380Posted about 3 years agoHey there, congrats on completing this challenge.
I recommend you using "background-position-y: center" on the input image to center it vertically in the input field.
And for the result section, I think you should add the dollar symbol to get it close to the design as possible.
0 - @greasypicadilloSubmitted about 3 years ago
Hello All,
Hope you are well. This is by no means a pixel perfect recreation but I did have some fun with it.
Some glaring problems for me: The share icon button looks a tad elliptical instead of nice and perfectly round Share icon does not change color properly The tooltip on the desktop design does not properly toggle off (this one really bugged me because I can't figure what changes to make to my script to make it function properly. Should be under the showDesktopSocial() if you can tell me where I went wrong.
Also would love some tips for Unobtrusive Javascript! read a bit about it and want to implement on future projects.
Thanks so much! I really appreciate anyone reading this and replying with constructive criticism!
Best Regards, Aidan Wright
@mikester380Posted about 3 years agoHey Aidan, congratulations on completing this challenge.
You can try setting a width and height on the share icon and using border-radius: 50%; on it to make it a perfect circle.
Also, try reducing the height of the component so it can match the given design and use flexbox to center it vertically on the screen.
And as for the tool tip you complained about, I was unable to view your source code on github and give you a possible solution. Try fixing that so I can try my best to help you
0 - @amstelmachSubmitted about 3 years ago
Hello! This is my first challenge with Frontend Mentor. Any feedback & suggestions would be highly appreciated! :)
How readable my code is? How can I improve readability of my code ?
I've tried to match the design as close as possible - I think I've managed to do so, but please judge it by yourself!
Thanks, Alicja
@mikester380Posted about 3 years agoHey there, good job on completing your first challenge. I've previewed the website and discovered it's not responsive, try fixing it so as to work on smaller devices.
0