Generalissimo• 110
@General4904
Submitted
My only problem with the project was that I didn't know how to import fonts from the net. I'll be glad if anyone can help with that.
P
Michael Hatton
@mikehwebdev
All comments
- PMichael Hatton• 270
@mikehwebdev
Posted
Kevin Powell is always my go to guy for CSS topic if a video covering Google fonts would help. 👍
Marked as helpful
1 - donovangg• 80
@donovangg
Submitted
Nothing really special. Might have missed some vertical padding or more...
PMichael Hatton• 270@mikehwebdev
Posted
This looks really good. The biggest differences I see are margin/padding on top of "Perfume", line-height on the "Gabrielle Essence Eau De Parfum" and padding on the button itself. This will bring the elements in the right hand column down a bit and more closely match the design I think. :)
Marked as helpful
0 - PMichael Hatton• 270
@mikehwebdev
Submitted
A good little project. I suspect I can refactor the code down a bit which I'll come back to but hopefully the code is straightforward to read. The JS was more complicated than I initially thought and took a bit of googling.
PMichael Hatton• 270@mikehwebdev
Posted
Had to correct my JavaScript as the currentDate variables weren't being reset which gave me lots of odd results.
0 - AryanSoni4119• 40
@AryanSoni4119
Submitted
PMichael Hatton• 270@mikehwebdev
Posted
This is really close to the design. I think the biggest issue you have is that the height and width would be better off set in rem.
Kevin Powell is great at explaining this if you aren't familiar. :)
0 - mohamedEssam2004• 550
@mohamedEssam2004
Submitted
PMichael Hatton• 270@mikehwebdev
Posted
This all looks good but I think there are some differences in element positions caused by the width being off on the "left" and "right" divs.
I'd start by correcting that and then I'd double check the font sizes and any margins to adjust it all into position :)
Good luck!
Marked as helpful
0 @tolutunji
Submitted
what is the best way to put a design at the center of the page?
PMichael Hatton• 270@mikehwebdev
Posted
There are a lot of ways to center a div but my favourite is:
display: grid; align-items: center; justify-content: center; min-height: 100vh;
Just another note looking at your design I think you've missed off the font family there buddy. It's listed in the style guide as:
- Family: Outfit
- Weights: 400, 700
Good luck!
0
