@omar-kamal-elkhabbatySubmitted over 1 year ago
Michael Reyes
@michaelr47All comments
- @michaelr47Posted over 1 year ago
Hey nice job Omar. One thing you might've forgotten is that upon clicking the dice icon, you should fetch a new random quote 🎲. Trying using an event listener on the image, happy coding! 😀
Marked as helpful1 - @AtlasKaplanSubmitted over 1 year ago
have a lot of fun with this, have a little issue with the card number input, i know i can improve the regex for the spaces, but overall the project works, any feedback or how can i improve is welcome :)
@michaelr47Posted over 1 year agoHello AtlasKaplan! Just a few suggestions to keep in mind, the form lets me submit it without the correct length of characters in the card number, expiration and cvc input fields. Trying adding for example,
if (cardNumber.length !== 16)and so on with the other two input fields. Other than that, good job!Marked as helpful1 - @daldev14Submitted almost 2 years ago
Hi 👋, here is my solution to the challenge. Any suggestion for improvement is welcome
@michaelr47Posted almost 2 years agoCode is well structured and readable, great solution! 😁
0 - @gian-nocheSubmitted almost 2 years ago
Hello there!
- What are some ways I could have used to make this more accessible? I only focused on the original price for this project.
- Any more appropriate semantic HTML I could have used?
- Did I use any unnecessary CSS properties or declarations?
Thank you!
@michaelr47Posted almost 2 years agoGood stuff! Ideally, instead of using the
<section>tag, using the<main>would be more semantically correct in this case since its the main part of the content you're wrapping around. Section tags could be used inside main tags though.. Other than that, everything is spot on imo! 😁Marked as helpful0 - @safira1003Submitted almost 2 years ago@michaelr47Posted almost 2 years ago
Nice desktop layout solution! I had trouble making the prices and main heading more bolder too haha 😁
0
