making the picture change with the layout
meredithincode
@meredithincodeAll comments
- @NaeemSlayerSubmitted 3 months agoWhat challenges did you encounter, and how did you overcome them?@meredithincodePosted 3 months ago
Great job at getting the responsiveness working. One of the things I can see that could be improved would be the font weight of the main price. You can see that in the original design there is heavier font weight to give emphasis to the new price. Other than that, great work! I hope this helps!
Marked as helpful1 - @MaskeyDudeSubmitted 4 months agoWhat are you most proud of, and what would you do differently next time?
Completing it :) and I'll try making it more organized...
What challenges did you encounter, and how did you overcome them?Not knowing how to style the markdowns of list but I did it so yay...
What specific areas of your project would you like help with?Um... how do I take a proper mobile version's screenshot
@meredithincodePosted 4 months agoGreat work, looks very much like the original design! Minor change, the bold in the instructions section in the original design looks slightly darker. Other than that, looks perfect!
Marked as helpful1 - @RahimthedevSubmitted 4 months agoWhat are you most proud of, and what would you do differently next time?
I am happy that I did this challenge without any help.
What challenges did you encounter, and how did you overcome them?Sometimes I have trouble with the responsive part but I will try. I will pay more attention to the responsive part in future challenges.
What specific areas of your project would you like help with?None
@meredithincodePosted 4 months agoFantastic work! Looks almost exact. The biggest difference I can see is that the height of the background link colors is a bit more on the original design, and yours is a little thinner.
0 - @centralparksharkSubmitted 4 months ago@meredithincodePosted 4 months ago
Excellent job! I can't tell the difference between yours and the original file, which shows you know your HTML and CSS.
0 - @colleennicole223Submitted 4 months agoWhat challenges did you encounter, and how did you overcome them?
Haven't used a shadow box yet, I had to look it up on MDN web docs to make sure I was handling it correctly 😅
What specific areas of your project would you like help with?I defined my colors as CSS variables in the body{} section, is there a more traditional way to assign 'changing' variables in CSS - or is this the way to go?
@meredithincodePosted 4 months agoHTML looks great and exact, you did a great job on this. Updating the HTML to include a main section looks like it was a big improvement to the CSS. It also looks like you've implemented the shadow box since your original upload. To answer your question about the CSS, it would be in the "main" section, which it looks like you've gone ahead and implemented already. Great work!
0