This challenge is very good to understand how display grid and display flex works. Especially knowing how to separate the sections of your layout. A very fun challenge for us beginners! I am open to hearing new solutions and feedback!
Mohamed Abdul Rahman
@mdabdulrahmanAll comments
- @davidFreelance19Submitted about 2 years ago@mdabdulrahmanPosted about 2 years ago
Hi @davidFreelance19,
Your solution is awesome ๐
Tip to avoid warnings in the accessibility report :
1.Wrap all the content in the
<main>
tag so you couldn't get the lanmark warningsI have seen all your solutions are nice. Can we work together?
Marked as helpful1 - @MarwaanAbdallaSubmitted about 2 years ago
This is my first solution to try in this platform I'm beginner in web dev I would like to know if I did it according to the challenge, I'll appreciate your feedback.
@mdabdulrahmanPosted about 2 years agoHi @MarwaanAbdalla,
Welcome to Frontend mentor community, Your first solution is awesome and keep it up.
Some advices 1.Wrap all the content in the
<main>
tag so you couldn't get an landmark error.2.Use the alt attributes for images
Marked as helpful1 - @taldr27Submitted about 2 years ago
Hello, I have a question:
- How can I put the footer correctly on the page? I tried with absolute, but when the size changes, the footer overlaps. Thank you
@mdabdulrahmanPosted about 2 years agoHey @taldr27,
Your Solution is really good!
1.Use atleast one
<h1>
tag so you couldn't get the warning.Marked as helpful1 - @sbetavSubmitted about 2 years ago@mdabdulrahmanPosted about 2 years ago
Hi @sbetav,
Your Solution is really good!
Tips :
1.Wrap all the content in the
<main>
tag so you couldn't get an landmark error2.Use atleast one
<h1>
tagThanks!
Marked as helpful1 - @NTWayysSubmitted about 2 years ago
Thank you for looking.
@mdabdulrahmanPosted about 2 years agoHi @NTWayys,
Your Solution is Great ๐ Some Tips,
1.Wrap all the content in the
<main>
tag so you couldn't get an landmark error.0 - @YabeshyjSubmitted about 2 years ago@mdabdulrahmanPosted about 2 years ago
Hey @yabeshyj
Welcome to Frontend mentor community,
Your Solution is great๐ :
Wrap the all the content in the
<main>
Marked as helpful1 - @MohamedAtTopSubmitted about 2 years ago
Every comment is helpful for me
@mdabdulrahmanPosted about 2 years agoHi Mohamed, Your Solution is looks Good!
Some of my suggestions are :
1.Change the background color of body to
hsl(212, 45%, 89%)
because this color is in the design2.Wrap all your content in
<main>
tag, so you couldn't get any landmark errorsI hope this will helpful to you, Thanks!
Marked as helpful0 - @MelvinAguilarSubmitted about 2 years ago
Hi there, Iโm Melvin and this is my solution for this challenge. ๐
- I add a delay and a spinner during loading to prevent the user from spamming the button. Do you think the spinner is accessible enough?
- What tips would you give me to improve the accessibility of the page?
Any feedback on how I can improve and reduce unnecessary code is welcome!
Thank you. :)
@mdabdulrahmanPosted about 2 years agoHi @MelvinAguilar,
Your solution is really awesome ๐ but one thing box shadow for dice button is showing only in bottom but in the design it should be all around the dice add this
box-shadow:0 0px 35px 1px #52ffa8;
CSS box-shadow code to dice button it will make box-shadow all around the dice buttonMarked as helpful1 - @abdulrehmandevSubmitted about 2 years ago@mdabdulrahmanPosted about 2 years ago
Hi @abdulrehmandev,
Your solution looks Good! Some of My suggestions,
1.Change Background color white to
#fafafa
because this color is mentioned in design2.In learn more button It seems your adding a border when hovering just add a border to learn more button and make border color to
#141414
when hovering change the border color to#fafafa
3.Reduce the padding size of the learn more button
4.Give more padding top to the header
That's All!
Marked as helpful0 - @AndreaDev14Submitted about 2 years ago
Hello, Frontend Mentor community! Here is my solution to the Advice generator app. Happy to hear any feedback and advice ๐๐ป๐
@mdabdulrahmanPosted about 2 years agoHello @AndreaDev14,
Your is solution really looks great ๐ and only thing you missed is box-shadow when hovering the dice. Add this CSS code to the dice button
box-shadow:0 0px 35px 1px #52ffa8;
0 - @CachiloxSubmitted about 2 years ago
Any advice is accepted.
@mdabdulrahmanPosted about 2 years agoHi @Cachilox,
It looks good, but one advice change the background color white to #fafafa.
0 - @tascintraSubmitted about 2 years ago@mdabdulrahmanPosted about 2 years ago
Hi @tascintra,
Your Solution is really great๐ Make the background color to #fafafa because design contains this color as bg color for a body.
Marked as helpful0