@EvonuXSubmitted almost 5 years ago
Been a while since I've made anything in React, also my first project using hooks! Let me know how if you like it and if I missed something :)
mbcod3
@mbcod3All comments
- @mbcod3Posted almost 5 years ago
I think there is some routing fix needed. Country page is not accessible with direct link
0 - @mbcod3Submitted almost 5 years ago
I used triangle and pentagon images as background. But had to reduce its size for mobile devices. So I used backgroundSize: 250px 250px.
The problem was unexpected as it thinned the triangle and pentagon lines. Can you explain why? How do I avoid lines being thinned?
@mbcod3Posted almost 5 years agoThank you. I asked that because in the images it seems mobile and desktop has same thickness for triangle and pentagon background.
Anyway if you are saying its unavoidable and it looks good this way I am good with that.
0 - @mbcod3Submitted almost 5 years ago
I used radio buttons for accordion and feature tabs and checkbox for mobile nav menu . Should I use javascript instead in production websites instead of these css hacks?
@mbcod3Posted almost 5 years agoI totally missed the accessiblity part. Thanks for pointing that out
0 - @mbcod3Submitted almost 5 years ago
I used picture tag for display curved images for three sections. Is it bad to use html element for such images?
- @mbcod3Submitted almost 5 years ago
How to scale up or down a fixed width background image like bg-curve image in this challenge while keeping its shape as original as possible?
Using position:cover alters the shape hence image curves dont display as original in width more than 375px for mobile and for desktop more than 1440px.
@mbcod3Posted almost 5 years agoThanks a lot for your reply. I modified my own fylo code that I did for previous fylo project and I was thinking why I have min-height there. In the end I just left it there in this dark project as well.
I just completed huddle with curved sections. In that I used picture tag for those curve images. Since svg scale up and down perfectly those shapes are almost identical regardless of screen size. The only thing I was wondering was that is it a good idea to use html element for background images?
0 - @mbcod3Submitted almost 5 years ago
I used JS setCustomValidity to disable tool tip for invalid form. Is there any pure css method too?
@mbcod3Posted almost 5 years agoI didnt add it because I am still using html5 validations. In case input is invalid only then I use custom validation and add classes to inputs to have that error text and exclaimation mark.
0 - @mbcod3Submitted almost 5 years ago@mbcod3Posted almost 5 years ago
Thank you for asking me. It was great. It was more for practice and writing code completely on my own then learning something new since its just a newbie challenge. I look forward to more advanced challenges am sure I will learn something new then.
One thing that was confusing was that all challenges image showed pricing section in a card design even for landing page challenges but this was just a section so I had to look for solutions to understand If I was supposed to create a section for a full page or like card design as in the image.
Secondly it would be great if solutions were organized and each challenge get its own page and all solutions for that challenge shown on that page instead of scrolling down many pages to find all solutions for one specific challenge.
0
