Skip to content
OverviewSolutions
4
Comments
5
Marija Havaic
@marijahavaic

All comments

  • Himanshu Tegyalwar•195
    @himanshuatSubmitted almost 2 years ago

    Hi there 👋

    I took a little bit more time than expected as this is my first react mini-project. I gave my best shot here, but love to get more suggestions from the community regarding my approach, improvements etc. Please leave your valuable suggestions for me.

    Advice generator app

    1
    Marija Havaic•150
    @marijahavaicPosted almost 2 years ago

    Hi Himanshu, Your project looks great! :)

    I find this kind of project perfect for trying out Different ways to fetch API in React.

    Hope it helps! :)

    0
  • Marija Havaic•150
    @marijahavaicPosted almost 2 years ago

    Hi Tan, your solution looks great! You could check your font sizes in the navbar as the dropdowns' font seem slightly bigger than the links. Also, when I hover over the second dropdown, the first one stays open in the desktop version, and they don't open/close in the mobile version (I used Chrome for the browser). Hope it helps! :)

    Marked as helpful
    0
  • Adigun Israel Collins•880
    @IcyEazySubmitted almost 2 years ago

    I couldn't do the hamburger menu for mobile screen size, so I had to use Bootstrap. Please you can drop comments on how I can get it done myself without the help of Bootstrap and also how to improve my code more efficiently and professionally, thank you.

    intro-section-with-dropdown-navigation

    2
    Marija Havaic•150
    @marijahavaicPosted almost 2 years ago

    Hi Adigun,

    here are some resources that helped me with the dropdowns and the sidebar.

    Hope it helps! 😊

    Marked as helpful
    1
  • yishak abrham•2,150
    @yishak621Submitted almost 2 years ago

    user experience question : do u think it's a good idea to close the dropdown card(links under a specific nav-lists) after a user clicks on the dropdown card links? if it is not recommended i will fix that

    Intro-section-with-dropdown-navigation

    2
    Marija Havaic•150
    @marijahavaicPosted almost 2 years ago

    Looks great! I agree, closing the menu would be even better. You could maybe consider the hover effect on desktop dropdown menus, from a UX perspective I think they are a much better choice.

    I have noticed that the .nav-slide has a red border and .aside-wrapper slides in when you open the menu. Not sure if this was intentional or not (I used Google Chrome as a browser). :)

    Marked as helpful
    1
  • Marija Havaic•150
    @marijahavaicPosted over 2 years ago

    Hey, I can see a few things you could improve:

    • in style-guid.md there is a font that is used for this project (you can easily get it from https://fonts.google.com/)
    • there's a background image in images folder pattern-background-desktop.svg which you can add as background-image property in CSS

    Hope it helps!

    Marked as helpful
    1