Skip to content
OverviewSolutions
6
Comments
5
Mariam Dakhil
@mariam-iq

All comments

  • Cegeeenre•50
    @CegeeenreSubmitted over 2 years ago

    Hi. I discover grid on this exercise. It's pretty strong. Responsive have problems. I think the dimensions is the problems. Thanks for viewing my work, sorry for my french english

    Testimonials grid in HTML, CSS

    1
    Mariam Dakhil•190
    @mariam-iqPosted over 2 years ago

    Hello Cegeeenre , I hope you had a good day.

    your code is amazing, i have a little advice for you, I hope that helps

    Cegeenre you have five cards almost the same design so you can put the same class for all names,photos and text on your design you need only to change color and background per card and design general shape by flexbox, grid or both.

    Also you can use normalize css search on it.

    I hope my feedback will be helpful. You can mark it as useful

    Good luck on coding

    Marked as helpful
    0
  • Mariam Dakhil•190
    @mariam-iqPosted over 2 years ago

    Hello Matinwk, I hope you had a nice day .

    I see your code you doing well, but I have some feedback on your design maybe help you :

    -The margin and padding you do not use it good ,you can know what the suitable number by using inspect on your website.

    • This files "design , gitignore , README-template.md , style-guide.md" its put to help you in your solution so when you submit your solution you can delete it.

    -And you can use normalize.css its so helpful to make solution perfect ,search on it.

    I hope my feedback will be helpful. You can mark it as useful

    Good luck.

    Marked as helpful
    0
  • Mariam Dakhil•190
    @mariam-iqPosted over 2 years ago

    Hello Isaac, I hope you had a good day

    your code is amazing, keep improving your programming skills, I have little advice for you.

    You can use normalize.css its so helpful to make solution perfect ,search on it.

    Also you can use nesting in css more in your code that made it more perfect

    I hope my feedback will be helpful. You can mark it as useful

    Good luck on coding

    0
  • Mariam Dakhil•190
    @mariam-iqPosted over 2 years ago

    Hi Erik , how are you doing,

    your code is amazing, but I have some feedback on your github files

    this files "design , gitignore , README-template.md , style-guide.md" its put to help you in your solution so when you submit your solution you can delete it.

    And you can use normalize.css its so helpful to make solution perfect ,search on it.

    I hope my feedback will be helpful. You can mark it as useful

    Good luck on coding

    Marked as helpful
    0
  • Mariam Dakhil•190
    @mariam-iqPosted over 2 years ago

    Hi merhan, how are you doing?

    I see your code its really good but there is a little advice to make it better

    -first: when you use @media Rule to make your website responsive u do not need to repeat it every line , I think it better to write all media in one in the last of css file like this

    ''' @media (max-width:992px) {

    main .container .content .rate .box {

    width: 100%;

    margin: 20px auto;

    flex-direction: column;

    text-align: center;
}

    .main .container .content .rate .box:nth-child(2),

    .main .container .content .rate .box:nth-child(3) {

    margin-left: 0;

}

    .main .container .content .rate .box .stars {

        margin-right: 0;

    margin-bottom: 10px;
}

    ect... } '''

    -second: your stars in the second box have not a good shape, you can solve the problem by change the width of box.

    I hope my feedback will be helpful. You can mark it as useful

    Good luck on coding

    Marked as helpful
    0