Paulina• 350
@testerium
Submitted
Thibaut Lefevre
@malboyoo
All comments
- Thibaut Lefevre• 120
@malboyoo
Posted
Hello Paulina,
few smalls things to improve a lot :
- There is an SVG named "icon-arrow.svg" in the images folder you can use it for the button.
- The background is missing in the left area, don't forget to add it.
- Work on the responsive design
If you need more details/help don't hesitate to contact me!
Marked as helpful
0 - Jack Tubbenhauer• 170
@jtubbenhauer
Submitted
Not sure how to handle the short delay after the new quote has been displayed. There should probably be some feedback letting the user know they can click the button again.
Thibaut Lefevre• 120@malboyoo
Posted
Hi,
I used this method to set a CD on the button:
in your event listener of your button, when the user click change the style with a new class, then after 1800ms(use setTimeout()) you can set class to the original value. I personally set the opacity to 0.6 and removed the hover effect When the button is disable. I also disabled the button during this time.
You can check my solution for more details.
good luck and keep working 👍
Marked as helpful
0 - Chris Nowicki• 140
@chris-nowicki
Submitted
The most difficult part for me was the sizing for different screens. Once I got through that then most of it was straight forward.
I'm not sure about the way I connected to the API as I see so many ways to do this. Input definitely appreciated.
Thibaut Lefevre• 120@malboyoo
Posted
simple and effective.
- maybe you can add variables to your css next time 👍
your code is very clean! goodjob by the way.
0 - Vernacci• 70
@Vernacci
Submitted
I would really appreciate some feedback about the code and responsiveness.
Thibaut Lefevre• 120@malboyoo
Posted
Hi,
Maybe you can do some improvement with the design:
- set a fixed height to avoid your container change with the advice.
- centering your button vertically.
- add letter spacing and a ligther policy to the adivce id title.
- there is a little box shadow on the container box, you should add it.
- dice should be a square.
if you want some help you can add me on slack.
Marked as helpful
0 - Thibaut Lefevre• 120
@malboyoo
Submitted
Thibaut Lefevre• 120@malboyoo
Posted
Hi there, it is my first project, i'm taking any advices, thanks ❤️️
0
