Latest comments
- @yuriinykSubmitted 11 days ago@majid-techPosted 11 days ago
You've done a great job on this project! I have a couple of suggestions that could further improve your code:
-
Error Message Placement:
- On lines 21 and 22, the error message could be wrapped in a
<span>
element inside the<label>
tag. This would help keep the error message aligned with the label usingfloat: right;
, ensuring that all elements stay on the same line. - Currently, because a
<p>
tag is used, the error message pushes theinput[type="email"]
field downward when rendered. - Here's an improved approach:
<label for="email" class="label"> Email address <span id="error-message"></span> </label>
#error-message { color: red; font-size: 14px; float: right; /* Aligns the error message with the label */ display: none; /* Initially hidden */ }
- On lines 21 and 22, the error message could be wrapped in a
-
Responsiveness:
- The desktop view looks great! However, I recommend improving the responsiveness of the page. When viewed on smaller screens, some elements don't adjust properly to the screen size.
- You could use flexbox, CSS grid, combined with the media query to ensure a smooth experience across different devices.
Overall, great work! Keep it up! 🚀
0 -
- @m-abubakr1Submitted about 1 month agoWhat are you most proud of, and what would you do differently next time?
Found new methods in CSS animations, using various complex techniques with CSS properties like
What challenges did you encounter, and how did you overcome them?inset
,transform/translate
properties, etc. Will do it again by using some CSS Preprocessors as well.The Active design of the mobile version was difficult to understand first, but once I git to know how it's possible using
inset
property, it got half easy, other half was still a hassle to know what values are needed, but thanks to codewithsadee, I got helped.@majid-techPosted about 1 month agoIt was well structured and I have learnt from it.
1