@MAY55ASubmitted 3 months ago
Daniel Gómez-Sánchez
@magicDGSAll comments
- @magicDGSPosted 3 months ago
Well done! Even with your custom info! Keep going!
Just one comment about your CSS: I would recommend not to style with IDs, as it is not the best practice - better to style with classes, so styles can be re-used.
0 - @abdelkarim-el-manssouriSubmitted 3 months ago@magicDGSPosted 3 months ago
Great job!
Some comments anyway:
- Font-sizes and margins/paddings look a bit off compared to the screenshoot
- Avatar is a bit big
- Keeping the attribution on the card makes more difficult to review the sizes
Marked as helpful0 - @RadishSoundSubmitted 3 months agoWhat are you most proud of, and what would you do differently next time?
The design seems very close to the example thanks to the figma design. I use all the variable from the design.
What challenges did you encounter, and how did you overcome them?I was challenged by a probleme of padding with the text section. I didn't understand why the width of the container change while i fixed it. With few research on internet, i find the solution with box-sizing. Also, I did'nt see that the width and the height were wixed in the figma design so I didn't think to fixed it for the container.
What specific areas of your project would you like help with?All
@magicDGSPosted 3 months agoLooks quite nice, congratulations!
Some comments and suggestions just to add something more:
- In the design screenshot, it looks like there is a shadow missing below the card - adding it would be a nice thing too (not sure if it is in Figma, as I am not using it)
- A nitpick comment: looks like the image border-radius is a bit too much compared to the design screenshot
- Add classes to style instead of directly into the elements
- Wrap the image in a container to ease the styling and prevent some layout shifts
Marked as helpful0
