Skip to content
OverviewSolutions
25
Comments
1
Madhavan
@madhavan-ts

All comments

  • Naveen CB•420
    @Naveen-CBSubmitted 10 months ago

    I learn new many concept from this project, it may be look like simple but it has definitely some stuff to make it interesting.

    Profile Card using HTML and CSS

    1
    Madhavan•340
    @madhavan-tsPosted 10 months ago

    @Naveen-CB You have done a great work making the webpage as close as possible to the design. I too have completed this challenge today, I may not be very experienced person to give a comment, But these are the suggestions that came for my code and I saw same issues on your code

    The HTML code of yours is clean and simple but there are some suggestions i would like to give

    1. Use <link> tag in your HTML file when using fonts rather than using @import in CSS when you are accessing an external font like Google Fonts. Reason : Performance, Link tags can help your website fonts render faster.
    2. About semantic HTML, you can replace your div.container with main.container because every HTML page must have a main section.
    3. For semantic reasons, and since your page does not have a main title, you can replace the <p> with <h1> on the name of the person.

    All these tag changes may have little or no visual impact but they make your HTML code more semantic and improve SEO and optimization as well as the accessibility of your project.

    And you can add the box-shadow property to the card to make a popout effect.

    Other than these you have done a great job and this was the most accurate implementation i have ever seen which is so clean.

    Marked as helpful
    1