comments are welcome :)
Mahmoud Ashraf
@m-Ash1All comments
- @dovanaiteSubmitted almost 3 years ago@m-Ash1Posted almost 3 years ago
I can't really catch any difference between the two designs so GOOD JOB! I just have one comment on the photo overlay. you can add a
transition: 0.3s;
to make the hovering event smoother. but at all good job and keep up :)Marked as helpful1 - @m8tboxxSubmitted about 3 years ago
What can I improve? What did I make good?
Thanks in advance
@m-Ash1Posted about 3 years agoAmazing job in placing the component and constructing the layout. you just can add transition to the image and the heading. And also I like the way you used the naming way of bootstrap like container, wrapper , etc..
Marked as helpful0 - @casserole27Submitted about 3 years ago
I previously completed the order component summary card, and I feel I have improved on this project, especially flexbox, responsiveness, and accessibility. Any feedback is appreciated!
@m-Ash1Posted about 3 years agoHello C Lewis, You are doing great. But the size is bigger than the design it's not a critical problem. so I just recommend this extension Pixelzoomer to extract lengths and heights from the original design and use it in your code :)
Marked as helpful1 - @Mariam-RfSubmitted about 3 years ago
This is my first project submitted on Frontend Mentor. Any feedback on how to layout my components on the screen in smarter and more efficient way are well appreciated!
@m-Ash1Posted about 3 years agohey Mariam, Amazing job dealing with the component. I had some comments on your code
- Use
height: 100vh; overflow: hidden;
to make your workflow all the screen not just upper side from it -on one-screen pages only- - Use
display: flex; justify-content: center; align-items: center;
to centralize the card instead of using margin cuz' you already know flex box
finally I recommend you checking this game Flexbox Zombies it will make it easier for you to deal with flexbox and also it's funny game :)
Marked as helpful1 - Use