All comments

• 

  Alan Torino• 60

  @Alan08t

  Submitted almost 2 years ago

  Hello everyone!

  In this, my first project presented on this platform, I have decided to choose the first project that the platform provides us with.

  So while the design is very simple, that doesn't stop me from practicing my flexbox skills, I'm very surprised at how much we can save on code with more practice.

  It's amazing!

  Well, for me it is a pleasure if you, dear community of this beautiful profession, can give me your opinion to learn more and more!! Thanks for reading me and my horrible English 😅😅.

  

  Simple Flexbox solution of this QR project!

  2

  60

  

  Luz De La Rosa• 100

  @luztherose

  Posted almost 2 years ago

  Hi Alan 👋🏾

  Congratulations on completing this challenge. Your solution looks great. I have some suggestions regarding your solution if you don’t mind:

  I suggest that you keep all your CSS in one place. It's great that you have your external stylesheet, so you could move the styles that you have in the index.html to your stylesheet.

  For better accessibility, try to use semantic elements whenever possible. For instance, the <div class="container"> could be replaced with the main tag, <main class="container"> , and this <div class="attribution"> could be <footer class="attribution">

  Overall Excellent work! Hopefully, this feedback helps.

  Marked as helpful

  1
• 

  Giridharan• 10

  @GiriRock

  Submitted about 2 years ago

  

  QR code component

  2

  20

  

  Luz De La Rosa• 100

  @luztherose

  Posted about 2 years ago

  Hi Giridharan 👋🏾

  Congratulation on completing this challenge. Your solution looks great. I have some tips regarding your solution if you don’t mind:

  • When writing your HTML always try to use semantics elements whenever possible. For example header, main, h1, p, footer, instead of divs.

  • The text for the alt="QR" attribute tries to make it as descriptive as possible since this is the text that will be displayed if the image cannot be loaded. for example alt="This is a QR code to frontend mentor".

  • For naming your stylesheet, you could use a more standard name like style.css(optional)

  Overall Excellent work! Hopefully, this feedback helps.

  0
• 

  Josepablo Ellis• 30

  @Josepablo333

  Submitted about 2 years ago

  

  Html, Css

  4

  20

  

  Luz De La Rosa• 100

  @luztherose

  Posted about 2 years ago

  Hi Josepablo,

  Congratulation on completing this challenge. Your solution looks good, but I have some tips that I think could help for future projects:

  • Structure your HTML using semantics elements whenever possible. For example header, main, footer, etc.

  • Always add the alt="" attribute and it should be always filled out with descriptive text for the image since this is the text that will be displayed if the image cannot be loaded. For example alt="This is a QR code to frontend mentor".

  • Pay close attention to the design to add the margin, padding, colors, etc.

  Overall good effort! Hopefully, this feedback helps.

  0
• 

  Ben Akaager• 210

  @Benaks

  Submitted about 2 years ago

  Project was easy, but there could be issues. point em out please...

  

  made with css flexbox

  2

  30

  

  Luz De La Rosa• 100

  @luztherose

  Posted about 2 years ago

  Hi Ben,

  Congratulation on completing this challenge. Your solution looks great. I have some suggestions regarding your solution if you don’t mind:

  1. When writing your HTML always try to use semantics elements whenever possible. For example header, main, footer, etc.

  2. The text for the alt="code" attribute tries to make it as descriptive as possible since this is the text that will be displayed if the image cannot be loaded.

  3. Since you are using an external stylesheet which is excellent, you could move the style that is written internally in the HTML for the footer to your external CSS and remove it from your HTML.

  Overall Excellent work! Hopefully, this feedback helps.

  Marked as helpful

  1