Skip to content
OverviewSolutions
9
Comments
15
Luigi
@luigi-perone

All comments

  • Luigi•240
    @luigi-peronePosted 9 months ago

    Hi, your submit is almost perfect, just one litte thing you should double the padding between the div.qr-container and the div.heading-container.

    Happy coding :)

    Marked as helpful
    1
  • Luigi•240
    @luigi-peronePosted 9 months ago

    Hello Hashesh congrats on finishing the challenge! You have done a good job, just one suggestion for the shadow of the box you could use CSS box-shadow Property that is more immediate.

    Happy code!

    0
  • Luigi•240
    @luigi-peronePosted about 2 years ago

    Hi Aviral, and welcome to the Frontend Mentor community!

    You've a great solution here but there are some tags you can consider changing in the html,the first div should be wrapped with a main tag and div with class attribution should be wrapped with a footer tag. These changes don't change the design but improve the accessibility and semantic.

    Hope it helps, happy coding 👋

    Marked as helpful
    1
  • Luigi•240
    @luigi-peronePosted over 2 years ago

    Hi @kennyoyaf, and welcome to the Frontend Mentor community!

    You've a great solution here but there are some tags you can consider changing in the html, the first div should be wrapped with a main tag and the div with name class should be wrapped with an h1. These changes don't change the design but improve the accessibility and semantic.

    Hope it helps, happy coding 👋

    0
  • Luigi•240
    @luigi-peronePosted over 2 years ago

    Hi Eduardo, and welcome to the Frontend Mentor community!

    You've a great solution here but there are some tags you can consider changing in the html,the first div should be wrapped with a main tag and div with class attribution should be wrapped with a footer tag. These changes don't change the design but improve the accessibility and semantic.

    Hope it helps, happy coding 👋

    Marked as helpful
    0
  • Iam Johnson•40
    @ultraiamSubmitted over 2 years ago

    I feel like this page could be more responsive using bootstrap, but I'm trying to stay away from frameworks at the moment while I get more proficient at using CSS. If there's anything in the code I can improve please feel free to let me know.

    QR Component

    2
    Luigi•240
    @luigi-peronePosted over 2 years ago

    Hi Iam, and welcome to the Frontend Mentor community

    You've a great solution here but there are some tag you can consider changing in the html,the first div should be wrapped with a main tag and div with class attribution should be wrapped with a footer tag. These changes don't change the design but improve the accessibility and semantic.

    Hope it helps, happy coding 👋

    0
  • Luigi•240
    @luigi-peronePosted over 2 years ago

    Hi Erick,

    You've a great solution here, but you can consider to add a main tag in the index.html file and in it the <div id="root"></div> .These changes don't change the design but improve the accessibility and semantic.

    After that, img tag must have alternate text GET EXPLAINED HERE so u should update

    <img src="./../images/image-qr-code.png">

    to

    <img src="./../images/image-qr-code.png" alt="qr-code-image">

    Hope it helps, happy coding 👋

    Marked as helpful
    0
  • Luigi•240
    @luigi-peronePosted over 2 years ago

    Hi Mariam,

    You've a great solution here but there are some tags you can consider changing in the html, for example, the div with bold class should be wrapped with an h1, you can also replace the first div with an main tag. After that img tag must have alternate text GET EXPLAINED HERE so u should update

    <img src="images/image-qr-code.png">

    to

    <img src="images/image-qr-code.png" alt="qr-code-image">

    Hope it helps, happy coding 👋

    0
  • Luigi•240
    @luigi-peronePosted over 2 years ago

    Hi @ZILLABB, and welcome to the Frontend Mentor community 👍

    You've a great solution here, but you can consider to add a main tag in the index.html file and in it the <div id="root"></div>. These changes don't change the design but improve the accessibility and semantic.

    Hope it helps, happy coding 👋

    0
  • SHMITEnZ•80
    @SHMITEnZSubmitted over 2 years ago

    Hello Frontend community! This is my solution for the [Product Preview Card] challenge

    This is my very first Frontend Mentor challenge: I'm very new to the coding world so I'll be happy to receive any advice to help me improve my solution or clean my code.

    I had a lot of fun working on this even if it took me longer than I thought. I still have a hard time giving all the divs and elements the correct size and make the design responsive. For the images I used the html <picture> tag but I would welcome any suggestion about a different approach on this and in general any best practice for a better responsiveness.

    I'm looking forward to any feedback! Thanks! 👋

    Product preview card with CSS flexbox

    2
    Luigi•240
    @luigi-peronePosted over 2 years ago

    Hi @SHMITEnZ, congratulations for your first solution! And welcome to the Frontend Mentor community 👍

    You've a great solution here, I advise you to switch to the junior challenges, newbie challenges are too simple for you 😁.

    happy coding 👋

    0
  • Luigi•240
    @luigi-peronePosted over 2 years ago

    Hi @Chiku100,

    You've a great solution here but there is a tag you can consider changing in the html, the div with class attribution should be wrapped with a footer tag. These changes don't change the design but improve the accessibility and semantic.

    Hope it helps, happy coding 👋

    1
  • Luigi•240
    @luigi-peronePosted over 2 years ago

    Hi Mateo, welcome to the Frontend Mentor community 👍

    You've a great solution here but there are some tags you can consider changing in the html, for example, the h2 should be wrapped with an h1, you can also replace the first div with an main tag and you can change the div with attribution class as a footer tag. These changes don't change the design but improve the accessibility and semantic.

    Hope it helps, happy coding 👋

    Marked as helpful
    1