All comments

• 

  Tejaswini Labade•150

  @TejaswiniLabadeSubmitted over 2 years ago

  Hi, I completed testimonials site using CSS Grid. Any feedback is really appreciated.

  

  Testimonials grid section challenge

  2

  20
  

  Lucas Weidas•1,350

  @lucasweidasPosted over 2 years ago

  Good job in that one!

  You have a problem centering the main container. To fix it, just add these lines to your body tag.

    min-height: 100vh;
    display: flex;
    justify-content: center;
    align-items: center;
  

  Then, remove the margin: 100px auto 0; line inside your media querie in .container.

  Keep it up!

  Marked as helpful

  1

  This comment has received 1 replyShow
• 

  Louise Norrsén•140

  @louisenorrsenSubmitted almost 3 years ago

  I am very happy with this solution! This is the first time that I get really close to the design image!

  I would like feedback on how I can make the code more effective, it feels like it is a little bit unorganized right now.

  Thanks!

  

  Order summary component

  1

  50
  

  Lucas Weidas•1,350

  @lucasweidasPosted almost 3 years ago

  Good job on that!

  Something I think you need to improve: change the div in payment-btn and cancel-order-btn to a button tag. Use div only as a generic container.

  Keep it up.

  Marked as helpful

  0
• 

  Ankitha Pai•20

  @ankithapaiSubmitted almost 3 years ago

  i dont know how to use github well as of now hence i cant host it

  

  Website QR code

  3

  30
  

  Lucas Weidas•1,350

  @lucasweidasPosted almost 3 years ago

  great job on that one!

  First of all, you have two folders with the same name, but the first one is useless. So, you need to move your second folder called qr-code-component-main out of the first one, and add on your Webdev folder. This change will make the github page identify your index.html and the page will work just fine.

  Keep it up.

  Marked as helpful

  1

  This comment has received 1 replyShow
• 

  alt_plusF4•120

  @alt-plusF4Submitted almost 3 years ago

  Feedbacks, please! Thank You.

  

  Fylo data storage component using basic HTML CSS

  1

  20
  

  Lucas Weidas•1,350

  @lucasweidasPosted almost 3 years ago

  Nice work on that one! But you need to wrap all your main content, in this case it is div class="bg" and div class="mid", inside a main tag. Also, you can wrap your div class="attribution" within a footer tag. Keep it up!

  Marked as helpful

  0

  This comment has received 1 replyShow
• 

  Nakoya Wilson•1,530

  @nakoyawilsonSubmitted almost 3 years ago

  Any suggestions on how I can improve are welcome!

  

  Fylo data storage component using Flexbox and CSS Grid

  1

  60
  

  Lucas Weidas•1,350

  @lucasweidasPosted almost 3 years ago

  Nice job, Nakoya Wilson! I see a small problem with the background-image in your body. To fix it, just set this code.

  @media (min-width: 1440px) {
      body {
          background-size: 100% 52.5%; 
      }
  }
  

  Marked as helpful

  0

  This comment has received 1 replyShow
• 

  Laura Stevenson•50

  @laurstevensonSubmitted almost 3 years ago

  Still grasping responsive designs, mobile version still needs some work (troubles with border-radius). Any feedback would be appreciated!

  

  Pricing Panel Challenge, HTML & CSS

  2

  50
  

  Lucas Weidas•1,350

  @lucasweidasPosted almost 3 years ago

  Greate job, Laura!

  To fix the "main" landmark problem, you need to wrap the "div.panel" with the "main" tag.

  To fix border radius trouble, change the "@media (max-width:500px)" to "@media (max-width:899px)", and the two class ".pricing-plan" inside them, to:

  .pricing-plan:first-child { border-radius: 10px 10px 0 0; } .pricing-plan:nth-of-type(3) { border-radius: 0 0 10px 10px; }

  Sorry for my bad english :)

  0

  This comment has received 1 replyShow