Skip to content
OverviewSolutions
26
Comments
5
Copper2
@long-1810

All comments

  • Zainabnofiu•80
    @ZainabnofiuSubmitted over 1 year ago

    Any suggestions on how I can improve are welcome! How do I go about adding image of car or the car icons to the project? I'm also not sure of the correct padding and font size of the texts.

    3-column preview card component

    2
    Copper2•410
    @long-1810Posted over 1 year ago

    Nice work!

    • The images are located in the images folder when you download the assets for this project. To use the images, use the <img> tag (Find more about the img tag here)
    <img src="..." alt="..." />
    • Your borders should be rounded in the first card and the last card. This can be done by using pseudo-selectors :first-child and :last-child. Specifically, your code should be like this
    .inner-card:first-child {
    border-radius: 15px 0 0 15px;
}
.inner-card:last-child {
    border-radius: 0 15px 15px 0;
}
    0
  • Copper2•410
    @long-1810Posted over 1 year ago

    I suggest you add * {box-sizing: border-box;} (Find out more about this property here) to make the design more consistent. This applies to this simple page and also many more complicated ones.

    0
  • Copper2•410
    @long-1810Posted over 1 year ago

    First of all, congrats on completing this challenge.

    But I have to address 2 main problems in this solution:

    • The filter should only display cards that satisfy all the tags. In your solution I saw that even if the card only satisfy 1 tag, you display it anyway.

    • You forgot to implement the Clear button

    Nevertheless, great job!

    0
  • kohicha•340
    @kohichaSubmitted over 1 year ago

    With this project, I learned the importance of functions. This was fairly easy but it currently isn't perfect. I'll come back to this project once I learn a framework and advance my Javascript skills more. Kudos to everyone working hard!!!

    Age calculator app with TailwindCSS

    1
    Copper2•410
    @long-1810Posted over 1 year ago

    It seems like your calculating process is broken. I tried inputting the current date and it returns -1 years

    0
  • Copper2•410
    @long-1810Posted over 1 year ago

    The button is too big. Maybe you can size it down to ~3rem of width and height and set the dice in the middle

    1