Skip to content
OverviewSolutions
3
Comments
3
Loic Duong
@loicduong

All comments

  • Max Sakuma•30
    @msakuma-devSubmitted about 1 month ago
    What are you most proud of, and what would you do differently next time?

    I think the design is pretty close to the original one, given I didn't get the Figma files at all to compared. I'm happy that using rem for font-sizes and other things are becoming more natural.

    What challenges did you encounter, and how did you overcome them?

    It was great to get more basic understanding on how some properties of CSS don't cascade at all and practicing the layout.

    To size the buttons how I wanted it actually took me a while...

    What specific areas of your project would you like help with?

    Moving forward I must pay more attention to ARIA attributes, since I haven't been using it so far, but it's definitely something everyone is looking for.

    Social Links Profile using BEM

    1
    Loic Duong•50
    @loicduongPosted about 1 month ago

    Hi @msakuma-dev. I think your project turned out great! However, I have some feedback that I think might be useful:

    • Images must have alt text unless it is a decorative image, for any decorative image each IMG tag must have empty alt="" and add aria-hidden="true" attributes to make all the assistive technologies of the Web, as screen reader.
    • You can try setting the font weight of the button and name to 700.
    • The spacing between the name and location should be reduced, perhaps to 4px.

    I hope this is helpful. 👍

    Marked as helpful
    0
  • Antonio•20
    @AntonioALV92Submitted about 1 month ago
    What are you most proud of, and what would you do differently next time?

    I am happy with my CSS implementation with the mobile-first workflow, as long as I continue with this workflow I will be better.

    What challenges did you encounter, and how did you overcome them?

    I learned how to implement a variable font and how to use clamp function on CSS for responsive fonts. Also I remembered how it works the box-sizing property. I could resolved reading the documentation.

    Responsive blog preview card

    1
    Loic Duong•50
    @loicduongPosted about 1 month ago

    It looks like the box-shadow size doesn't match the design

    0
  • Loic Duong•50
    @loicduongPosted about 1 month ago

    Missing semantic HTML

    0