Skip to content
OverviewSolutions
1
Comments
3
Luís Monteiro
@lmonteiro18

All comments

  • Luís Monteiro•30
    @lmonteiro18Submitted almost 3 years ago

    I'd like to structure my CSS better and create reusable classes through CSS methodologies. Is BEM a good Methodology? What is the best way to learn about it? Does my solution present a good responsivity?

    Responsive Component using CSS Flexbox

    4
    Luís Monteiro•30
    @lmonteiro18Posted almost 3 years ago

    Updated code files and hosted website with the suggestions made! There's yet a problem with the "a" tag inside the collection image, i can't seem to change its dimensions so it takes the same amount of space the image does (to cover it all)...

    0
  • Archana Vaideeswaran•10
    @ArchanaVaideeswaranSubmitted almost 3 years ago

    My first front-end challenge!!! I have done it with whatever knowledge I have. It was fun implementing this challenge. Any comments and suggestions would be highly valuable to me.

    NFT Preview Card Component

    1
    Luís Monteiro•30
    @lmonteiro18Posted almost 3 years ago

    Since this is your first challenge it's normal that you miss some things. So in order for you to improve I'll point out topics you might wanna look into:

    • Alignment (you can use css basic properties or you can use a system like flexbox or css grid);
    • Responsiveness (the design's ability to adapt across devices with different proportions and sizes); you can search for css media queries to help you with this;
    • CSS Transitions - these enable you to smooth some property value's change like background-color or position; right now the changes triggered by your hover states happen instantly and with transitions you could specify the duration of the change and apply easing;

    Despite my suggestions, good work! Keep practicing! I also have much to learn!

    Marked as helpful
    0
  • Luís Monteiro•30
    @lmonteiro18Posted almost 3 years ago

    The solution is somehow close to the desired aspect however there are some issues:

    • Hover on the image isn't finished (eye icon missing and cyan color not applied);
    • Image is left aligned so when it gets to a lower height right margin starts to get bigger than the left one while other parts of the card keep the same space between them and card borders;
    • Creation text should be closer to the creator image and not aligned to right;
    • Things don't usually keep the same dimensions across devices, even though in this case it actually didn't break on smaller devices;
    • Not quite sure why the design comparison shows a deformed screenshot, with text falling out of the card;

    Also you used the tag "#sass" but you don't use it. If you don't use any different technology you don't need to use a tag. The important part is that you learn new things and complete the challenge.

    1