All comments

• 

  Eeshma Karim• 180

  @Eeshma123

  Submitted 2 months ago

  

  QR Code Card Component using HTML & CSS

  1

  50

  

  lioba-s• 30

  @lioba-s

  Posted 2 months ago

  Hi,

  congrats on completing the challenge! 🎉

  You did well with structuring your HTML and CSS. In your "index" file, you can additionally make sure to indent all nested elements. It's good practice to be consistent here.

  What's most apparent in the design comparison (see above) is that your image isn't displayed. Maybe you've noticed this. You need to change its name in your html file - as you don't have an "images" folder, take this part out. Do the same for your favicon image.

  There are a couple of files you don't need in your github project. They aren't messing with your design as seen above; you can still make it a bit cleaner by deleting what you don't need 😊

  Happy coding 😊

  Marked as helpful

  0