Fidel A Hernandez Jr• 130
@FHernandez08
Submitted
Linda Jensen
@lindajensen
All comments
- Linda Jensen• 80
@lindajensen
Posted
I think that overall you did a great job. I just noticed that in mobile view the text that's not in boxes disappeared which is kind of problematic. At least it did on my laptop when I made the viewport smaller.
I also noticed that you started with an <h4> and I'm not a 100% sure but the way I've been taught is that you shouldn't skip heading levels. You can read more on W3 Schools (https://www.w3schools.com/tags/tag_hn.asp)
0 - marchena290• 120
@marchena290
Submitted
Linda Jensen• 80@lindajensen
Posted
Looking at your code I'm guessing you're way more advanced than me hahah I think you did a great job! The product card is almost identical. The only suggestion I can give you is have a look at how to write alt-texts. I've come across quite a few sources that suggest writing kinda short and straight to the point alt-text and not being too detailed. But my experience and knowledge is not a lot so I could be wrong.
Good job and happy coding!
0 - vardalonur• 20
@vardalonur
Submitted
What are you most proud of, and what would you do differently next time?
There are probably incorrect or unnecessary entries both on the html and css side. But this is my first project and I tried to interpret everything I know. The next one will be better.
Linda Jensen• 80@lindajensen
Posted
I mean it's not exactly like the design image, but then again neither is mine. I found this challenge kind of difficult. If I could give a friendly suggestions it would be to put the headings in descending order (h1, then h2, then h3 and so on).
Good job and happy Coding!
Marked as helpful
0 - BT738844• 600
@BT453567
Submitted
What are you most proud of, and what would you do differently next time?
n/a
What challenges did you encounter, and how did you overcome them?
n/a
What specific areas of your project would you like help with?
I would like to know how the code compares to professionally written code.
Linda Jensen• 80@lindajensen
Posted
So I don't think I can tell you how your code compares to professionally written code because I've only been coding for like 6 months. But I do think you seem to have done a good job. Your project looks a bit smaller than the design image but I wouldn't have known that without the comparison image above.
I hope you have a great evening and happy coding!
1 - amina-refik• 80
@amina-refik
Submitted
What are you most proud of, and what would you do differently next time?
I have utilized semantic web tags.
What challenges did you encounter, and how did you overcome them?
Correctly sizing the article illustration in the mobile view is challenging due to the image ratio. I was able to resolve it by using object-fit: cover;.
What specific areas of your project would you like help with?
I can't figure out how to properly space the elements.
Linda Jensen• 80@lindajensen
Posted
I think your it looks really great. I haven't been coding for very long so it's kind of hard to give feedback and offer solutions to the areas you need help with. The only thing I can think of is that it looks like the height of your card is a bit off. But then again I never would have known that if i didn't have the design image straight next to your version. I decided to put a height on my card, but I'm so not sure if that's how you're suppose to solve it.
Good job and happy coding!
0 - SIBI• 80
@sibi404
Submitted
What are you most proud of, and what would you do differently next time?
I completed the challenge earlier than I expected I will try to optimize the code next time and try to make more responseive
What challenges did you encounter, and how did you overcome them?
Using font is little bit confusing
What specific areas of your project would you like help with?
Responsiveness and code optimization
Linda Jensen• 80@lindajensen
Posted
I haven't really been coding that long so it feels weird giving feedback to someone who's probably been doing it a whole lot longer than me. I think you did really good. Especially with the padding (around the QR-code and text) which you did waaay better than me. Good job!
I'm sorry I can't really help you with your questions because I have too little experience and knowledge to do so.
0
