This project was interesting with the cards, I found most of it pretty straightforward, although I swapped the font-family between the h1 and the p as they looked like they had the opposite font when I applied what was stated in the style guide so I am not sure if maybe the style guide was wrong or if it was something on my end?
I decided to go with Grid for the cards, which worked pretty well for me!
Overall feedback and/or suggestions of code changes would be greatly appreciated for me to take into my next projects. :)
The button is only shrinking and becoming round when the cards become very small, and the container goes below max-width of 375px you set. The button has a max-width of 63% of the card. There may be better ways to do this but a few options I can think of.
give the button a width instead of max-width
Leave the button with a max-width but stop the card from shrinking below a certain size and accept that its just not suitable for really small screens.
Allow the card and to shrink furthert, but use some other media query to modify the button, perhaps width 100% smaller font, less padding etc.
Personally I would lean towards option 2. Phones with screen sizes less than 375px are decreasing the majority seem to be in the 412-414px range or at least thats what google tells me.
This project was interesting with the cards, I found most of it pretty straightforward, although I swapped the font-family between the h1 and the p as they looked like they had the opposite font when I applied what was stated in the style guide so I am not sure if maybe the style guide was wrong or if it was something on my end?
I decided to go with Grid for the cards, which worked pretty well for me!
Overall feedback and/or suggestions of code changes would be greatly appreciated for me to take into my next projects. :)
Nice work on this, one thing I would consider looking at is when you resize the screen and you hit the first breakpoint and it flips to a coumn, the whole cards are stretched out. This may be by design, but it might be worth lookin at fixing the width and centering the column of cards. Similarly because of this resizing if you push it too far the button becomes round.
