Frontend Mentor | Ledi Hildawan's profile

sonickonic•700

@sonickonicSubmitted over 4 years ago

Mobile first site using Sass, Flexbox, BEM and JS

1

Ledi Hildawan•140

@ledihildawanPosted over 4 years ago

Awesome! I read the code and I think is clean. You've 9 Accessibility issues.

In the navbar, I think you forgot to make an ID on each section.
SVG in the tag a should have a text, you can use span than make it hidden for sr-only.

Keep it up!

Do u have a discord account? I need a friend on this field. Here is my username Ledi Hildawan#8691

0

Opeyemi Yusuf•90

@mrohizzySubmitted over 4 years ago

Hello Solution providers,

Here's my second challenge solution, but I believe improvements can always be made.

I'll appreciate getting honest feedback also, which is best for this challenge between Flexbox or Grid.

Thanks.

Single price grid component using css flexbox & media-query

1

Ledi Hildawan•140

@ledihildawanPosted over 4 years ago

First, thank you for seeing my solution.

I think this to big and spacing. I've got the same problem too with that. However, it is a challenge when doing "perfect pixel" when don't have the design file, I mean like file sketch and others. But I think just my excuse.

I hope we get better day by day.

0

Sahas saurav•745

@SahasSauravSubmitted over 4 years ago

any recommendation is accepted

manage with scss bem swipper.js flexbox and grid

1

Ledi Hildawan•140

@ledihildawanPosted over 4 years ago

How about the shapes? Looks good also code is clean 👍

0

Wojtek•410

@SamoloteSubmitted over 4 years ago

Feel free to submit any feedback! ^_^

Progressive Enhancement of HTML form and Constraint validation API

1

Ledi Hildawan•140

@ledihildawanPosted over 4 years ago

Nice, you are using BEM methodology for naming classes. I see the functionality is working. The title font-size is different form the design. You have 7 Accessibility issues and 1 HTML issues please fix it.

It will be nice if you just remove "Challenge by Frontend Mentor. Coded by Samolote.".

0