Lahiru Shiran
@lahirusb97All comments
- @ecln30Submitted over 2 years ago@lahirusb97Posted over 2 years ago
i think you forgot to make it responsive
here myne :-https://www.frontendmentor.io/solutions/sunnyside-agency-landing-page-using-html-scss-js-9idcIroz4k
0 - @boonyarit-iamsaardSubmitted over 2 years ago
Hi everyone 👋,
Here is my solution. Please let me know your thoughts and how you approached the sizing and spacing in the JPEG design file.
Thanks for all feedback 👍
- @ghintemaSubmitted over 2 years ago
At first I didn't notice that there's supposed to be JS involved in this Challenge. So I started tackling the challenge using css only. Now I'm wondering what do you need JS for in this challenge? I think I got all the functionality and interactivity using only css. Did I miss something? To make the slidebar visible I used <input type="checkbox" id="Name"> and <label for="Name"> together with pseudo-class input:checked as selector.
Any feedback welcome and highly appreciated !!! :)
@lahirusb97Posted over 2 years agoi learned this just now ( input#hamburger-check:checked ~ #hamburger-icon) thanks you. i love that arrow rotating animation and side bar animation
1.after width1400px content is fixed to width 400px and centerd side have space 1000px white i think you can increse your text and image size to manage that large white space. try to look some design on dribble.com you will get the idea.
**** thanks you so much for the feedback i shouldn't use 2 nav bars like that ****
Marked as helpful0 - @Enmanuel-Otero-MontanoSubmitted over 2 years ago
Hello! This is my third challenge with Angular and my first time working with Firefox. Any suggestion is welcome.
@lahirusb97Posted over 2 years agoi am sorry i can't read your code because i don't know angular but here is my opinion about your design
1.your website is really mobile friendly and clean. 2.sidebar animation is really nice. if you can add same animation when sidebar closes i think all clean and good. 3.when sidebar opens background content gray overlay is really nice
thanks for the feedback for my design it's really helpful.
Marked as helpful0