All comments

• 

  Alessandra•10

  @ASemeraroSubmitted over 2 years ago

  Please, check my 'main' branch for the code.

  • I'm pretty sure I failed in making the site accessible. I would love any feedback on accessibility, since it's something I haven't explored yet.
  • If you go to my index.html, do you think I managed to follow the BEM naming convention? I would really like to incorporate it in my practice.
  • As for the rest, I would appreciate any kind of feedback 😀.

  PS: I'm aware this is a small project and setting up SASS took more time. But I feel like I can experiment more with smaller projects 😅.

  

  QR Card with HTML5, SASS, and BEM

  2

  50
  

  Kylee Bustamante•90

  @kyleebustamantePosted over 2 years ago

  I'm inspired by the fact that you used this simple project to learn beyond what it asked for! I think your solution looks nearly perfect. Great job! Fixing your accessibility issues is pretty simple. It can be resolved by wrapping your main content in <main></main> tags. In your case it would just be the card section above the footer.

  <main>
  <section class="card">
  </section>
  </main>
  <footer> 
  and so on...
  

  Marked as helpful

  1

  This comment has received 1 replyShow
• 

  Dinah Novema•50

  @DinahNovemaSubmitted over 2 years ago

  

  Responsive design

  1

  30
  

  Kylee Bustamante•90

  @kyleebustamantePosted over 2 years ago

  Hi Dinah, I just finished this challenge as well! Good job! I noticed you could resolve your HTML and Accessibility issues by:

  • Adding an alt attribute to your img tag <img src="/images/image-qr-code.png" alt="">
  • Wrapping the page content in <main></main> this identifies all the main content of the page
  • Lastly, to change the first <p> to an <h1> Semantically, every page should have at least one <h1>

  Marked as helpful

  1

  This comment has received 1 replyShow
• 

  Nneoma Njoku•1,210

  @SatellitePeaceSubmitted over 2 years ago

  1 Please did I structure my HTML properly?

  2 Did my CSS styling technique meet up to standard practice?

  3 Any more comments and criticisms is appreciated.

  

  I used html to structure qr code components and css grid to center it

  1

  10
  

  Kylee Bustamante•90

  @kyleebustamantePosted over 2 years ago

  Good job at attempting this challenge! Your HTML and accessibility errors could be resolved by:

  • Using <h1> instead of <h4>
  • Using <main> instead of <section> to wrap the page content

  Marked as helpful

  1